Closed
Bug 1048365
Opened 10 years ago
Closed 10 years ago
[Messages] Remove the "tap" action on the contact when in the report panel
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(feature-b2g:2.1, tracking-b2g:backlog)
VERIFIED
FIXED
2.1 S2 (15aug)
People
(Reporter: julienw, Assigned: steveck)
References
Details
(Keywords: feature, Whiteboard: [tako][p=1])
User Story
As a user I want to be better informed if a field is actionable so that I don't expect action when tapping at specific places. AC1: minimise confusion with a better design
Attachments
(1 file)
see attachment 8461328 [details] for the UX spec
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → schung
Assignee | ||
Comment 1•10 years ago
|
||
Hi Julien, here I only set event listener on multiple recipient view(I've confirmed with Jenny, we still need to show contact prompt on that view) and override the active styling. Maybe we will need report view visual refresh as well, but I think we can finish actionable field related issue first.
Attachment #8467566 -
Flags: review?(felash)
Updated•10 years ago
|
blocking-b2g: --- → backlog
feature-b2g: --- → 2.1
Updated•10 years ago
|
QA Whiteboard: [COM=Gaia::SMS]
Reporter | ||
Updated•10 years ago
|
Blocks: sms-sprint-2.1S2
Whiteboard: [tako] → [tako][p=1]
Reporter | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S2 (15aug)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8467566 [details]
Link to github
comments on github :)
let's do another review pass, please request review once you're ready !
Attachment #8467566 -
Flags: review?(felash)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8467566 [details]
Link to github
Some issue in last patch addressed, expect some test related question for you(on github), thanks!
Attachment #8467566 -
Flags: review?(felash)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8467566 [details]
Link to github
r=me with a small nit in CSS
about the test, I'd prefer to use a real list item, but I won't block on this.
Thanks !
Attachment #8467566 -
Flags: review?(felash) → review+
Assignee | ||
Comment 5•10 years ago
|
||
master: 18cb552b2e57171a003aa820d9e33892c05f0afb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
Hi Steve
Please uplift these to v2.0 as well!
Thanks!
Flags: needinfo?(schung)
Assignee | ||
Comment 8•10 years ago
|
||
Hi Wesley, it's part of 2.1 highlight actionable feature, do you think it's ok to just uplift one of them to 2.0?
Flags: needinfo?(schung) → needinfo?(whuang)
Comment 9•10 years ago
|
||
From my viewpoint I would suggest no.
At this moment we supposedly shouldn't do any feature uplift to 2.0 branch.
v2.0 is about to CC so people are expecting fixing actual release blockers.
Bug 1048365 is more like an UX improvement feature instead.
Flags: needinfo?(whuang)
Comment 10•10 years ago
|
||
Verified User story is fixed. Confusing info removed.
Gaia 2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID 20140831160203
Version 34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•