Closed Bug 1048433 Opened 10 years ago Closed 10 years ago

Clearing private data on exit: "Always clear when quitting" often cropped/truncated in localizations, provide more space

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Product:
Firefox for Android Graveyard
Component:
Settings and Preferences
Version:
33 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox33 ?, firefox34 wontfix, firefox35 verified, fennec35+)

Status:
VERIFIED FIXED
Milestone:
Firefox 35
Tracking Flags:
Tracking Status
firefox33 --- ?
firefox34 --- wontfix
firefox35 --- verified
fennec 35+ ---

People

(Reporter: aryx, Assigned: wesj)

References

Details

Attachments

(1 file)

Patch
(deleted), patch
mfinkle
: review+
Details | Diff | Splinter Review
Firefox for Android Aurora 20140804, Android 4.1.2, Nexus S Clearing private data on exit: "Always clear when quitting" often cropped/truncated in localizations, please provide more space. Localizations: http://mxr.mozilla.org/mozilla-aurora/search?string=pref_clear_on_exit_title E.g. for German, "Beim Beenden immer löschen" gets shortend to "Beim Beenden immer lös..."
tracking-fennec: --- → ?
status-firefox33: --- → affected
status-firefox34: --- → affected
Assignee: nobody → wjohnston
tracking-fennec: ? → 33+
I'm not sure we should fix this. Locales can drop words like "Always" if they need to (I don't even like having it in the English to be honest).
I think the English label is a bit wordy too. How about simply "Clear on exit"? The description below it offers enough context, I think.
(In reply to Joni Savage from comment #2) > I think the English label is a bit wordy too. How about simply "Clear on > exit"? The description below it offers enough context, I think. This change sounds fine. Can any locales just make the change themselves?
Can we message to localizers that they might want to use a shorter string. I'm renoming this, but will make a patch quickly. Would we want to uplift?
status-firefox33: affected → ?
Flags: needinfo?(jsavage)
I'd send a message to dev-l10n and also add a localization note to those strings where length is an issue.
Attached patch Patch (deleted) — — Splinter Review
Attachment #8498308 - Flags: review?(mark.finkle)
I'm not really familiar with how UI localization process works (I'm in SUMO). I think Jeff Beatty might know? "Need info'ing" him to find out.
Flags: needinfo?(jsavage) → needinfo?(jbeatty)
Attachment #8498308 - Flags: review?(mark.finkle) → review+
I second flod's suggestion. I don't think it needs to be uplifted beyond Aurora, and localizers will be able to adjust it once they see the string change.
Flags: needinfo?(jbeatty)
Blocks: 1001309
tracking-fennec: 33+ → 35+
https://hg.mozilla.org/mozilla-central/rev/50565aa74892
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
This should be fixed in the latest Fennec 35 builds (now in Aurora). Please verify this is fixed.
status-firefox35: --- → fixed
Flags: qe-verify-
Flags: needinfo?(archaeopteryx)
Yes, the shorter localized version doesn't get cropped in German (on my Nexus S) and most other translations are shorter: http://transvision.mozfr.org/string/?entity=mobile/android/base/android_strings.dtd:pref_clear_on_exit_title2&repo=aurora
Status: RESOLVED → VERIFIED
Flags: needinfo?(archaeopteryx)
Thank you :aryx. Wes, can you nominate this for uplift given that this bug is tracked for 35 and has been verified fixed?
status-firefox35: fixed → verified
Flags: needinfo?(wjohnston)
This is a string change. I don't think we can uplift it to 34. We're just telling localizers they can use a shorter string if they want. I am going to mark 34 wontfx if that's ok (UNDO!!! if its not :)
status-firefox34: affected → wontfix
Flags: needinfo?(wjohnston)
(In reply to Wesley Johnston (:wesj) from comment #14) > This is a string change. I don't think we can uplift it to 34. We're just > telling localizers they can use a shorter string if they want. I am going to > mark 34 wontfx if that's ok (UNDO!!! if its not :) Confirmed.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: