Hey Jenny, Just two quick questions regarding to the latest page in this spec: * If we move "Call" button to the header, should it still be duplicated in the contact menu (when tapping on recipient name)? * If not, we'll have single option in the contact menu ("View contact"), so should we keep single-item-menu or tap on header should lead to "View contact" directly without displaying menu?

(In reply to Oleg Zasypkin [:azasypkin] from comment #1) > Hey Jenny, > > Just two quick questions regarding to the latest page in this spec: > > * If we move "Call" button to the header, should it still be duplicated in > the contact menu (when tapping on recipient name)? > > * If not, we'll have single option in the contact menu ("View contact"), so > should we keep single-item-menu or tap on header should lead to "View > contact" directly without displaying menu? In the past I asked for having a single item menu here, in the same situation (the action was "call"). The menu acts as a "confirmation" menu, to prevent unwanted taps. But see also bug 1040874. If there is only this menu left, I think we'll just remove this menu in the end.

See also bug 1032273, it's related to this button.

Hi Wesley, Since this feature is separated from bug 1026694, could you please set flag (feature-b2g: 2.1) for this bug?

It's part of the visual refresh.

(In reply to Oleg Zasypkin [:azasypkin] from comment #1) Hello Oleg, see my comments below: > * If we move "Call" button to the header, should it still be duplicated in > the contact menu (when tapping on recipient name)? > Nope, let's remove it from contact menu. > * If not, we'll have single option in the contact menu ("View contact"), so > should we keep single-item-menu or tap on header should lead to "View > contact" directly without displaying menu? I think we should keep the menu for consistency, as in other cases, there can be more than one option. I don't think it's reasonable to go to view contact directly when this is the only available option, because the contact name itself doesn't imply the "view contact" function. So let's keep the on option menu for now. Tks :)

(In reply to Jenny Lee from comment #6) > (In reply to Oleg Zasypkin [:azasypkin] from comment #1) > > Hello Oleg, see my comments below: > > > * If we move "Call" button to the header, should it still be duplicated in > > the contact menu (when tapping on recipient name)? > > > Nope, let's remove it from contact menu. > > > * If not, we'll have single option in the contact menu ("View contact"), so > > should we keep single-item-menu or tap on header should lead to "View > > contact" directly without displaying menu? > > I think we should keep the menu for consistency, as in other cases, there > can be more than one option. I don't think it's reasonable to go to view > contact directly when this is the only available option, because the contact > name itself doesn't imply the "view contact" function. So let's keep the on > option menu for now. Tks :) Thanks for clarification!

Per product prioritization, this could be 2.2 focus.

Use feature-b2g:2.2? rather than just 2.2.

Hey Steve, Could you please review this patch? Thanks!

Comment on attachment 8483996 [details] GitHub pull request URL R=me, only some nits in test, thanks!

Thanks for review! Nits fixed and landed. Master: https://github.com/mozilla-b2g/gaia/commit/d0767fc24ff631afb2256ff3dc13ebca80a20f73

let's keep the already-landed improvement in 2.2.

Added a test case