Julien Wajsberg [:julienw] Reporter
	Description • 10 years ago

Idea is to
* disable shadow/radius and see how this impacts rendering
* discuss with Design team to come up with a solution, possibly display this only after some time.

	Oleg Zasypkin [:azasypkin] Assignee
	Comment 1 • 10 years ago

Ok, after a profiling and set of different experiments I don't see that manipulation with styles can bring us a lot of improvements in the end. I used two flames for side by side compassion. Here some results  + I've also recorded few video comparing different gaia/SMS variations comparing to reference Gecko v1.3 + Gaia v1.3):

- Gecko Master + Gaia Master + SMS Master:
  https://people.mozilla.org/~bgirard/cleopatra/#report=b77e364d587e3c61365855c842a48a754fdae125
  https://www.youtube.com/watch?v=vXXJR5quVNo

- Gecko Master + Gaia Master + SMS v1.3:
  https://people.mozilla.org/~bgirard/cleopatra/#report=70e0e1f12ed9da6c8eb910cf6c7eccf2e2524cda
  https://www.youtube.com/watch?v=uFZ6CHiBQFs

- Gecko Master + Gaia v1.3 + SMS v1.3
  https://people.mozilla.org/~bgirard/cleopatra/#report=0b1d87bc6d5e3653fedb9d77beba0078a3ccf614
  https://www.youtube.com/watch?v=1k49gDw01JA

- Gecko Master + Gaia v1.3 + SMS Master
  https://people.mozilla.org/~bgirard/cleopatra/#report=81335d2128a152b4943d25a3b9dd7045eb78c9a0
  https://www.youtube.com/watch?v=uFZ3Sk_ggD0

* Looking at profiles, I don't see much differences in reflow/paint for single thread item between SMS (master) and SMS (v1.3) using Gecko (master);

* At the same time both SMS (master) and SMS (v1.3) perform better (first displayed thread, first page of threads displayed) if Gaia (v1.3) is used that made me think that we have regression outside of SMS app, somewhere in Gaia (clearly visible if you see video in slow mode);
 
* Per last video it's noticeable that Gecko (master) + Gaia (v1.3) + SMS (master) do better job (first thread displayed, first page of threads displayed) than Gecko (v1.3) + Gaia (v1.3) + SMS (v1.3);

* Also it's interesting to note that Gecko (master) + Gaia (v1.3) + SMS (v1.3) is equal to Gecko (v1.3) + Gaia (v1.3) + SMS (v1.3) in displaying of the first page of threads, but it looses in loading of the full list of threads (see video). This either a coincidence or something slowed down a bit in Gecko.

	Julien Wajsberg [:julienw] Reporter
	Comment 2 • 10 years ago

Oleg, can you please try again with contact pictures ?

Our guess is that the contact pictures (with its rounded box-shadowed border) are slowing us down significantly.

See also bug 1003080: Joan changed the grey border by box-shadow because the border was not smooth. Maybe there is an underlying gecko issue for this that would allow us to move back to a normal grey border if this proves to be an issue.

Thanks!

	Oleg Zasypkin [:azasypkin] Assignee
	Comment 3 • 10 years ago

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Oleg, can you please try again with contact pictures ?
> 
> Our guess is that the contact pictures (with its rounded box-shadowed
> border) are slowing us down significantly.
> 
> See also bug 1003080: Joan changed the grey border by box-shadow because the
> border was not smooth. Maybe there is an underlying gecko issue for this
> that would allow us to move back to a normal grey border if this proves to
> be an issue.
> 
> Thanks!

Sure, but I still don't see any difference, looks like using box-shadow and border-radius is efficient enough in our case, but maybe I'm missing something, here are profiles and side by side comparison videos (it's better to see it in slow mode):

- Gecko Master + Gaia Master + SMS Master:
  https://people.mozilla.org/~bgirard/cleopatra/#report=238125cb5f5489df440f5014afbbb70230a4c68f
  https://www.youtube.com/watch?v=TCHapA3iS40

- Gecko Master + Gaia Master + SMS v1.3:
  https://people.mozilla.org/~bgirard/cleopatra/#report=bb297cca2d81772d2c4c90cda594bf0f495edda0
  https://www.youtube.com/watch?v=VGknInqZRss

- Gecko Master + Gaia v1.3 + SMS v1.3
  https://people.mozilla.org/~bgirard/cleopatra/#report=a9459d1164b435a962fc99524b3e86d305931987
  https://www.youtube.com/watch?v=6BAqWZSuu7s

- Gecko Master + Gaia v1.3 + SMS Master
  https://people.mozilla.org/~bgirard/cleopatra/#report=1644b5655cab52728e2092f86398a477900a0cda
  https://www.youtube.com/watch?v=EuIKEoMKiP4

And bonus...
- Gecko Master + Gaia Master + SMS Master without border-radius and shadow:
  https://people.mozilla.org/~bgirard/cleopatra/#report=da05337f24e4850ff7a3deee7a45dba5de6440cd
  Video #1 (vs Gecko v1.3 + Gaia v1.3 + SMS v1.3): https://www.youtube.com/watch?v=1BlpNZLpk2Q
  Video #2 (vs Gecko Master + Gaia Master + SMS Master): https://www.youtube.com/watch?v=eMyLbHAfGEs


Both Flames with v123 firmware, 19 threads with photos (from medium workload), 500 contacts.

	Oleg Zasypkin [:azasypkin] Assignee
	Comment 4 • 10 years ago

Hey Gabriele, 

NI? you, since you've been investigating this earlier and that would be great if you can confirm\abandon results I got once you have some time :)

Thanks a lot for help!

	Julien Wajsberg [:julienw] Reporter
	Comment 5 • 10 years ago

We found no obvious gain from this.

Gabriele, if you find anything useful, please comment here and we'll file a separate and more focussed bug. Thanks !

	Oleg Zasypkin [:azasypkin] Assignee
	Comment 6 • 10 years ago

Removing ni? for now as main bug 1038176 is going to be closed.

	Gabriele Svelto [:gsvelto]
	Comment 7 • 10 years ago

(In reply to Oleg Zasypkin [:azasypkin] from comment #6)
> Removing ni? for now as main bug 1038176 is going to be closed.

Thanks, sorry for not getting back at this but I've been caught up in other blockers :-/