Closed
Bug 1048865
Opened 10 years ago
Closed 10 years ago
Sync with upstream TwoWayView
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Upstream now has proper support for negative item margins and a few more code cleanups.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8467787 [details] [diff] [review]
Sync with upstream TwoWayView (r=mcomella)
This gives us proper support for negative item margins (and some nice code cleanups) which are going to be used in our tab strip implementation.
I don't actually expect you to review the changes btw. This is a standalone project open source project I maintain so I take full responsibility over the changes. Feel free to point out any obvious issues though.
Attachment #8467787 -
Flags: review?(michael.l.comella)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8467787 [details] [diff] [review]
Sync with upstream TwoWayView (r=mcomella)
Review of attachment 8467787 [details] [diff] [review]:
-----------------------------------------------------------------
A rubber stamp as I'm not familiar with the code.
Attachment #8467787 -
Flags: review?(michael.l.comella) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•