Closed
Bug 1049031
Opened 10 years ago
Closed 10 years ago
Create global configuration file for Gaia performance testing
Categories
(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S2 (15aug)
People
(Reporter: Eli, Assigned: Eli)
References
Details
(Keywords: perf, Whiteboard: [c=automation p=3 s=2014.08.15 u=])
Attachments
(1 file)
Gaia performance tests do not have a unified file for sharing configuration or constant data. Adding an INI file to the gaia/tests/performance directory and including an easy mechanism for consumption would improve maintenance.
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
First pass at implementing a global mechanism for holding performance testing utilities and configuration. Obviously this is a good-sized change with a bit of refactoring to take advantage of the new configuration and utilities. Also the format of the config file is open for discussion as well, I'd be happy to explain my logic behind this. :)
Attachment #8468160 -
Flags: review?(hub)
Assignee | ||
Comment 2•10 years ago
|
||
Also, I've tested this locally using:
APP=settings RUNS=10 make test-perf
VERBOSE=1 APP=communications/dialer make test-perf
APP=email RUNS=1 make test-perf
All tests ran fine with no errors, and all environment variables were recognized and respected.
Assignee | ||
Comment 3•10 years ago
|
||
Hub, just a note that the "goals" config section is just a placeholder and will be replaced with whatever data structure you deem fit for consumption.
Comment 4•10 years ago
|
||
I did comment on the PR.
Assignee | ||
Comment 5•10 years ago
|
||
PR updated with comments addressed.
Comment 6•10 years ago
|
||
Comment on attachment 8468160 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files
Ship it !
(you ran the test after these changes, didn't you?)
Attachment #8468160 -
Flags: review?(hub) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks Hub! And yes, I ran the same command set as before to be sure.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Whiteboard: [c=automation p=2 s= u=] → [c=automation p=3 s= u=]
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [c=automation p=3 s= u=] → [c=automation p=3 s=2014.08.15 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•