Closed Bug 1049063 Opened 10 years ago Closed 10 years ago

reflow on zoom is broken (again)

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(fennec-)

RESOLVED WONTFIX
Tracking Status
fennec - ---

People

(Reporter: blassey, Unassigned)

Details

If you enable reflow on zoom from settings -> display -> reflow text, when you double tap on text needing reflow your screen just kinda dances around and never zooms in. To enhance the effect, you can also select the extra large text size.
Karen, do we care?
Flags: needinfo?(krudnitski)
Just so I understand. Does this happen ALWAYS when you enable reflow on zoom from the settings menu?
Flags: needinfo?(krudnitski)
yes
Flags: needinfo?(krudnitski)
Huh. I'm using my ol' faithful www.ottawaathleticclub.com website. And I see what you mean. How about this for another dumb question. If 'double tap to zoom' is enabled as default (preffed on), does it work ok? Then it would only break if someone unchecked the box and checked it again?
Flags: needinfo?(krudnitski)
Where do you see "double tap to zoom"? Reflow zoom is broken if you enable it ("reflow text" pref under settings->display) and otherwise the app works fine.
Flags: needinfo?(krudnitski)
I have two apologies here. First, it looks like my comment late last week didn't come through. Second, I must be daft. When I enable 'reflow test' from the settings -> display menu, you're right - nothing happens. So here's my daft question. Why would we include it in the product if nothing happens?
Flags: needinfo?(krudnitski)
We're going to consider removing this feature altogether.
tracking-fennec: ? → -
(In reply to Karen Rudnitski [:kar] from comment #6) > I have two apologies here. First, it looks like my comment late last week > didn't come through. > > Second, I must be daft. When I enable 'reflow test' from the settings -> > display menu, you're right - nothing happens. So here's my daft question. > Why would we include it in the product if nothing happens? That's the question. It's broken now, but I don't think the feature is useful anymore with the modern mobile web. I'm recommending that we just disable the feature and remove the code rather than fix it.
Flags: needinfo?(krudnitski)
ah ha. We got there in the end. And we discussed this at last week's triage while you were enjoying PTO and came up with pretty much the same conclusion. I think this was useful a year ago, but I think now that the mobile web has moved on some, this feature's benefit does not outweigh the work required to get this fixed. Therefore I think we're all on the same page - let's remove this code.
Flags: needinfo?(krudnitski)
> Therefore I think we're all on the same page - let's remove this code. Should open a new bug to detail what would involved with this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
submitted bug 1059014 for the removal of code
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.