Closed
Bug 1049379
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor under mobile/android
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
upcoming gcc 4.9 can use std::is_destructible and NDK r10+ on some platforms can use gcc 4.9... So we should remove dangerous public destructor.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8474367 [details] [diff] [review]
fix
This is required for gcc 4.9 (upcoming NDK compiler).
Attachment #8474367 -
Flags: review?(blassey.bugs)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8474367 [details] [diff] [review]
fix
Review of attachment 8474367 [details] [diff] [review]:
-----------------------------------------------------------------
Brad is on PTO. Patch looks okay though.
Attachment #8474367 -
Flags: review?(blassey.bugs) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Assignee: nobody → m_kato
Target Milestone: --- → Firefox 34
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•