change appWindowManager from singleton to class.

waiting for test result.

Comment on attachment 8470592 [details] PR to master Hi Alive, I'm trying to make appWindowManager as class format. I think that would make sense if moving getActiveApp method to System.js, I'm also wondering that, should we also move getApp and getAppByURL to system, so that other module won't depend on appWindowManager.js ? could I have your opinion? Thanks.

I don't really object, but you need to change gaia_apps.js and marionette-apps as well. They are using AppWindowManager.getActiveApp() too. Evan please kindly help the marionette-apps part. Please note everything will be changed again later to |System.request('getActiveApp')|

Hi Alive, As I know, AppWindowManager.getActiveApp() is only used in Python Marionette[1], not in marionette-apps. JSMarionette uses navigator.mozApps[2] to get app list. So we only need to update Python Marionette. [1] https://github.com/mozilla-b2g/gaia/blob/master/tests/atoms/gaia_apps.js#L344 [2] https://github.com/mozilla-b2g/marionette-apps/blob/master/lib/scripts/getallapps.js#L25

Comment on attachment 8498589 [details] PR to master Hi Alive, could you review this patch? Gip fail due to bug 1079130.

Comment on attachment 8498589 [details] PR to master r+ with nits, thanks!

Thanks! master: https://github.com/mozilla-b2g/gaia/commit/c44510bb576ade5edce60c13eb8d18ee2c7a2ed2