Once fixes on bug 1047924 and bug 1047981 land, we can now take advantage of this and package extensions into the right locations.

See bug 1047924 comment#4 for why I don't understand this change.

(In reply to neil@parkwaycc.co.uk from comment #1) > See bug 1047924 comment#4 for why I don't understand this change. I would say the m-c equiv seems to be missing for that piece, and I'm not sure I comprehend the necessity of a change on that side.

Comment on attachment 8468668 [details] [diff] [review] Package xpis where they are [Checked in: Comment 6] Review of attachment 8468668 [details] [diff] [review]: ----------------------------------------------------------------- something about this looks wrong, can you please provide a local build log, snipped for ~ these commands (+ a slight bit of context) (in a -j1 make invoke would be ideal, so I don't get confusion in logs due to parallelism) Once I have that to go on, this will be a lot easier for me to review. ::: suite/app/Makefile.in @@ +125,4 @@ > # NOTE: This is a hack to run this at the end of compilation, would be nicer > # if this was done right away for built-in extensions in omnijar mode. > # Listed extension GUIDs: > +# 972ce4c6-... Classic Theme, 59c81df5-... ChatZilla, e2fda1a4-... Lightning This piece of adjusted comment is wrong, you're no longer losting extension GUIDs.

Comment on attachment 8468668 [details] [diff] [review] Package xpis where they are [Checked in: Comment 6] Review of attachment 8468668 [details] [diff] [review]: ----------------------------------------------------------------- r+ based on log. Thanks!

Comment on attachment 8468668 [details] [diff] [review] Package xpis where they are [Checked in: Comment 6] http://hg.mozilla.org/comm-central/rev/ea566228448a

(In reply to Justin Wood (:Callek) from comment #3) > Comment on attachment 8468668 [details] [diff] [review] > ::: suite/app/Makefile.in > @@ +125,4 @@ > > # NOTE: This is a hack to run this at the end of compilation, would be nicer > > # if this was done right away for built-in extensions in omnijar mode. > > # Listed extension GUIDs: > > +# 972ce4c6-... Classic Theme, 59c81df5-... ChatZilla, e2fda1a4-... Lightning > > This piece of adjusted comment is wrong, you're no longer losting extension > GUIDs. Removed the last two lines of the comment on checkin.