Closed
Bug 1049820
Opened 10 years ago
Closed 10 years ago
Make the Profiler Category and Framerate graphs themable
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: rcampbell, Unassigned)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
Currently the Profiler Categories Graph is light theme only. It should adapt to dark theme too.
Reporter | ||
Updated•10 years ago
|
No longer blocks: profiler-followups
Reporter | ||
Updated•10 years ago
|
Blocks: profiler-followups
Updated•10 years ago
|
Summary: Make the Profiler Category (Graph) themable → Make the Profiler Category and Framerate graphs themable
Updated•10 years ago
|
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Updated•10 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Updated•10 years ago
|
Blocks: perf-tool-v2
Updated•10 years ago
|
No longer blocks: perf-tool-v2
Updated•10 years ago
|
Blocks: perf-tool-v2
Depends on: 1087877
Comment 1•10 years ago
|
||
Quick test added for this, as we'll be deprecating this in favour of the new perf tool.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=272dfbd96658
Attachment #8544277 -
Flags: review?(vporof)
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8544277 [details] [diff] [review]
1049820-categories-graph-dark-theme.patch
Review of attachment 8544277 [details] [diff] [review]:
-----------------------------------------------------------------
So metal
::: browser/devtools/shared/widgets/Graphs.jsm
@@ +1605,5 @@
> let height = this._height;
>
> + // Draw the background.
> + ctx.fillStyle = this.backgroundColor;
> + ctx.fillRect(0, 0, width, height);
If you're doing this, remove the background from the css (if there is one, I can't remember). Probably in widgets.inc.css.
Attachment #8544277 -
Flags: review?(vporof) → review+
Comment 4•10 years ago
|
||
Ah, you're right -- removing extra CSS
Attachment #8544277 -
Attachment is obsolete: true
Attachment #8544297 -
Flags: review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
Backed out for apparently causing ASAN leaks (at least it certainly seems like the most plausible candidate from the push).
https://hg.mozilla.org/integration/fx-team/rev/afbe988c3bea
https://treeherder.mozilla.org/logviewer.html#?job_id=1604782&repo=fx-team
Comment 8•10 years ago
|
||
Possibly related bug 1118582
Comment 9•10 years ago
|
||
another ASAN try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b013932c5982
Attachment #8544297 -
Attachment is obsolete: true
Attachment #8548378 -
Flags: review+
Comment 10•10 years ago
|
||
Try looks good (I think), Should this be landed ?
Flags: needinfo?(jsantell)
Comment 11•10 years ago
|
||
the last ASAN try link has the obscure link failure as well, so this is not yet good to go
Flags: needinfo?(jsantell)
Updated•10 years ago
|
No longer blocks: profiler-followups, perf-tool-v2
Comment 12•10 years ago
|
||
We do not currently have a categories graph, so removing this from bug 1110550
No longer blocks: 1110550
Updated•10 years ago
|
Assignee: jsantell → nobody
Updated•10 years ago
|
Status: ASSIGNED → NEW
Comment 13•10 years ago
|
||
No longer have a category graph, and framerate graph responds to themes now, so closing this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•