Closed
Bug 1050026
Opened 10 years ago
Closed 10 years ago
b2g-info and get_about_memory.py fail if Nuwa process doesn't rename itself
Categories
(Core :: DOM: Content Processes, defect)
Tracking
()
RESOLVED
FIXED
2.1 S2 (15aug)
People
(Reporter: khuey, Assigned: dhylands)
References
Details
Attachments
(3 files)
A spin off from bug 1048024 comment 41.
dhylands is working on a patch.
Assignee | ||
Comment 1•10 years ago
|
||
I'm actually working on a patch to make b2g-info and get_about_memory not care whether the process is named Nuwa or not.
It looks at the pid, ppid, and the executable name to figure out which are child and master processes.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8469041 -
Flags: review?(tchou)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8469042 -
Flags: review?(tchou)
Comment 4•10 years ago
|
||
Comment on attachment 8469041 [details]
PR for get_about_memory.py
This is for get_about_memory.py actually, there're two minor comments.
Attachment #8469041 -
Flags: review?(tchou) → review+
Comment 5•10 years ago
|
||
Comment on attachment 8469042 [details]
PR for b2g-info
r=me after double check getuid() is needed, and the side effect from b2g_processes() is acceptable.
Attachment #8469042 -
Flags: review?(tchou) → review+
Comment 6•10 years ago
|
||
Dave, thank you for such a quick response. But I guess we still need to know why Nuwa is not renaming itself? I couldn't repro on my Flame though.
Assignee | ||
Updated•10 years ago
|
Attachment #8469041 -
Attachment description: PR b2g-info → PR for get_about_memory.py
Assignee | ||
Updated•10 years ago
|
Attachment #8469042 -
Attachment description: PR for get_about_memory_info.py → PR for b2g-info
Assignee | ||
Comment 7•10 years ago
|
||
https://github.com/mozilla-b2g/gonk-misc/commit/6822004d07064ea3ebbc0c94cd2e15be6a02069d
https://github.com/mozilla-b2g/B2G/commit/a5411c63509332d35a1566e10a9f40d8752fd32a
With these commits, b2g-info and get_about_memory.py should both work even when the Nuwa process doesn't get renamed.
I'm still seeing the Nuwa process showing with the name b2g:
> 2563 >adb shell b2g-ps
> APPLICATION SEC USER PID PPID VSIZE RSS WCHAN PC NAME
> b2g 0 root 306 1 170820 84144 ffffffff 00000000 S /system/b2g/b2g
> b2g 0 root 457 306 55680 5536 ffffffff 00000000 S /system/b2g/b2g
> Built-in Keyboa 2 u0_a943 943 306 88824 33688 ffffffff 00000000 S /system/b2g/plugin-container
> Homescreen 2 u0_a945 945 306 85348 38480 ffffffff 00000000 S /system/b2g/plugin-container
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Summary: The Nuwa process does not always change its name → b2g-info and get_about_memory.py fail if Nuwa process doesn't rename itself
Comment 8•10 years ago
|
||
I just read your updated b2g_processes() to address the side effect, and found a problem.
If you run |adb shell b2g-info -m|, main_process() will go through the for loop twice and complain there are two b2g main process which are the same pid. It's because main_process() is reentrant when m_main_process hasn't been set.
The same problem happens when you do a |adb shell b2g-info -p| or |adb shell b2g-info -c|.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•10 years ago
|
||
Addresses the reentrancy problem.
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8469292 [details]
PR for b2g-info (part 2)
I'll put tchou down to review unless I can find somebody else sooner.
Attachment #8469292 -
Flags: review?(tchou)
Reporter | ||
Comment 11•10 years ago
|
||
Comment on attachment 8469292 [details]
PR for b2g-info (part 2)
r=me
Attachment #8469292 -
Flags: review?(tchou) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•