Closed Bug 1050085 Opened 10 years ago Closed 9 years ago

Improve l10n comments

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: flod, Assigned: jsantell)

References

Details

Attachments

(1 file)

profiler.dtd Given the structure profilerUI.emptyNotice1+2 and profilerUI.stopNotice1+2, I'd assume these strings are concatenated with a button in the middle, like it happens on the Network tab. The localization comment should clearly explain that. Typo in comment for profilerUI.clearButton: "remvoes all the recordings" profiler.properties recordingsList.itemLabel=Recording #%S What's %S? Given the #, I'd say a number, but I shouldn't be guessing it. There should be an explanation of what %S is in the comment, and an example.
Priority: -- → P3
Summary: [Profiler] Improve l10n comments → Improve l10n comments
Assignee: nobody → jsantell
Depends on: 1167317
Assignee: jsantell → nobody
Depends on: 1163763
Attached patch 1050085-l10n-cleanup.patch (deleted) — Splinter Review
Seems like most of these were taken care of already, but here are the remaining ones
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8643413 - Flags: review?(francesco.lodolo)
Comment on attachment 8643413 [details] [diff] [review] 1050085-l10n-cleanup.patch Review of attachment 8643413 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #8643413 - Flags: review?(francesco.lodolo) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: