Closed
Bug 1050120
Opened 10 years ago
Closed 10 years ago
[keyboard] js-kanji IME hangs after loading dictionary file.
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S2 (15aug)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | fixed |
People
(Reporter: xyuan, Assigned: wdeng)
References
Details
Attachments
(1 file)
Steps to reproduce: 1. Refer to "apps/keyboard/js/imes/jskanji/README" to cook the "dict.json." 2. Use GAIA_KEYBOARD to enable "jp-kanji" when you reset gaia. e.g. `GAIA_KEYBOARD_LAYOUTS=en,jp-kanji make reset-gaia` 3. Enable Japanese-Kanji keyboard from settings page and touch any input field to show the Japanese keyboard. 4. Tap the "あ" key on the keyboard Expected: The keyboard responses to the input and show candidates for "あ". Actual: No candidate is available.
Assignee | ||
Comment 1•10 years ago
|
||
Hi rudy, It's just a small logic problem, thanks for your review.
Attachment #8469101 -
Flags: review?(rlu)
Comment 2•10 years ago
|
||
Comment on attachment 8469101 [details]
pull request 22618
Yuan, wdeng,
Thanks for the quick fix! r=me.
--
For the record, it seems jp-kanji was broken because we remove the call of engine.empty() in the original renderKeyboard() after we refactored the keyboard architecture.
Attachment #8469101 -
Flags: review?(rlu) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/80c88f1ef3237e735f204d7db24aac59ff89ebab
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•