Closed
Bug 1050702
Opened 10 years ago
Closed 10 years ago
Improve the use of strings in URLSearchParams
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
hsivonen
:
review+
neil
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8469926 -
Flags: review?(hsivonen)
Attachment #8469926 -
Flags: feedback?(neil)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8469926 [details] [diff] [review]
strings.patch
>+ if (NS_FAILED(rv)) {
[Should you NS_WARN_IF here?]
>+ if (newOutputLength < outputLength &&
>+ !aOutput.SetLength(newOutputLength, fallible_t())) {
>+ aOutput.Truncate();
You can replace this with
if (newOutputLength < outputLength)
aOutput.Truncate(newOutputLength);
which is always infallible.
Attachment #8469926 -
Flags: feedback?(neil) → feedback+
Attachment #8469926 -
Flags: review?(hsivonen) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•