Closed Bug 1051061 Opened 10 years ago Closed 10 years ago

[verticalhome] TypeError: this.grid._grid.dragdrop is undefined

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.1 S2 (15aug)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: djf, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

(deleted), text/x-github-pull-request
djf
: review+
cwiiis
: review+
Details
This error message can appear in the logcat, at least in version 2.0 I saw it first in bug 1050751 I traced it to app.js:200. The dragdrop module is lazy loaded, so it is possible for that code to run before the dragdrop property is defined. This is pretty obviously just a case where you need to test for its existance before using it. I can reproduce the error by launching an app, using adb shell kill to kill the homescreen and then rapidly tapping multiple times on the home button. This launches a new homescreen and then triggers that app.js:200 code before the lazy load is done. _grid.dragdrop is also used without checking in the context menu code, but I didn't try to cause an error there.
This should not cause any problems, but we should definitely fix it. Thanks for filing.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S2 (15aug)
Attached file Github pull request (deleted) —
David - any chance you'd be willing to throw a review stamp on this since you reported it? :)
Attachment #8470307 - Flags: review?(dflanagan)
Attachment #8470307 - Flags: review?(crdlc)
Blocks: 1048639
Comment on attachment 8470307 [details] Github pull request Hey Chris - any chance you have some cycles for a review? Thanks!
Attachment #8470307 - Flags: review?(chrislord.net)
[Blocking Requested - why for this release]: This is needed to help us solve bug 1048639 (a CAF blocker).
blocking-b2g: --- → 2.0?
Comment on attachment 8470307 [details] Github pull request LGTM + points for test :)
Attachment #8470307 - Flags: review?(chrislord.net) → review+
Comment on attachment 8470307 [details] Github pull request This looks good to me. I've noted a few nits on github, but nothing that I feel needs to be fixed. Consider adding a similar fix in the contextmenu event case in contextmenu_handler.js before landing.
Attachment #8470307 - Flags: review?(dflanagan) → review+
blocking-b2g: 2.0? → 2.0+
Comment on attachment 8470307 [details] Github pull request Thanks for the review guys. I'm making some minor updates to the code based on David's comments and will land this.
Attachment #8470307 - Flags: review?(crdlc)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
attachment 8470307 [details] has been landed in AU63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: