Closed
Bug 105166
Opened 23 years ago
Closed 23 years ago
premature page break printing nytimes.com
Categories
(Core :: Layout, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: karnaze, Assigned: karnaze)
References
()
Details
(Keywords: testcase, Whiteboard: PATCH CANDIDATE_094)
Attachments
(6 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
karnaze
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
alexsavulov
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
karnaze
:
superreview+
|
Details | Diff | Splinter Review |
This is a spinoff of bug 66804 which was fixed but got reopened because new urls kept getting added to it.
just wanted to explain here what the symptoms for this bug are since we're starting to get DUPS. banner or top graphic is being printed on first page. and rest of the content is being printed on sucessive pages..
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
In the attachment, the cell block containing the tall spacer gif (I increased the height to 1500 from 900 in the url) does not split. As a result, the table does not split, so the body puts the table on the next page to give it more space to truncate. One approach would be to split images when they exceed a certain percentage of the page height. Kevin, I'm not sure who should get this.
Assignee: karnaze → kmcclusk
Keywords: testcase
Assignee | ||
Comment 6•23 years ago
|
||
taking this back to investigate splitting images.
Assignee: kmcclusk → karnaze
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Whiteboard: PATCH
Target Milestone: --- → mozilla0.9.6
Comment 8•23 years ago
|
||
Comment on attachment 54323 [details] [diff] [review] patch to split images r= alexsavulov
Comment 9•23 years ago
|
||
Comment on attachment 54323 [details] [diff] [review] patch to split images sr=attinasi - way cool Chris!
Attachment #54323 -
Flags: superreview+
Assignee | ||
Comment 10•23 years ago
|
||
Comment on attachment 54323 [details] [diff] [review] patch to split images r=alexsavulov
Attachment #54323 -
Flags: review+
Assignee | ||
Comment 11•23 years ago
|
||
Comment 12•23 years ago
|
||
Comment on attachment 55971 [details] [diff] [review] revised patch sr=kin@netscape.com
Attachment #55971 -
Flags: superreview+
Comment 13•23 years ago
|
||
Comment on attachment 55971 [details] [diff] [review] revised patch r= alexsavulov
Attachment #55971 -
Flags: review+
Assignee | ||
Comment 14•23 years ago
|
||
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Comment 16•23 years ago
|
||
The patch is in.
Status: NEW → RESOLVED
Closed: 23 years ago
Priority: -- → P2
Resolution: --- → FIXED
Whiteboard: PATCH → PATCH CANDIDATE_094
Comment 17•23 years ago
|
||
verified in 11/2 trunk build on windows verified the following URLs print banner AND content together in continuous sequence on the same page: http://www.businessweek.com http://www.nytimes.com http://www.washingtonpost.com
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 18•23 years ago
|
||
Assignee | ||
Comment 19•23 years ago
|
||
Comment on attachment 56840 [details] [diff] [review] I guess I lied, this needs to be applied after the 5th attachment sr=attinasi
Attachment #56840 -
Flags: superreview+
Comment 21•23 years ago
|
||
Is fix applied to trunk yet - I'm confused by the latest comments. I'm running 2001110803 and problem still exists. Apologies if fix not applied yet.
Comment 22•23 years ago
|
||
this should be fixed in trunk builds....if not let me know... I will recheck
Comment 23•23 years ago
|
||
just verified on 11/9 trunk build. I printed http://www.businessweek.com and it printed out the banner and content together. Thus this is fixed still. here are other test URLs: http://www.nytimes.com http://www.washingtonpost.com
Comment 24•23 years ago
|
||
Downloaded trunk 2001111303 and tested with html scipt as posted on bug 80966 (my original post for this bug). The script is taken from a cisco web page. It does not print the table correctly. It should print the table following the text as does ie and netscape 4.76 and not start a new page. Also on the new page it prints the table header then leaves a gap which is done on the following page as well. This bug is not fixed in this build.
Comment 25•23 years ago
|
||
Steve, are you sure what you are describing is the same as this bug ? Why don't we take this discussion over to bug 80966
Comment 26•23 years ago
|
||
sujay, have you run the test as described? Bug 80966 was eventually transferred to this bug! It does prematurely print a page break! Isn't that what this bug is about? It's to do with determining how to print a table that is longer than the page length. And it's not fixed.
Assignee | ||
Comment 27•23 years ago
|
||
nytimes.com fluctuates between being fixed and not. Right now with an 11/13 debug build it prints ok for me. A few days ago that was not the case. This could be happening because the content on that pages changes often. But until someone can attach a case that fails, please leave this bug closed.
You need to log in
before you can comment on or make changes to this bug.
Description
•