Closed
Bug 1052371
Opened 10 years ago
Closed 10 years ago
ShutdownLeaks detector is deactivated and runs for mochitests other than bc
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox31 unaffected, firefox32 unaffected, firefox33 fixed, firefox34 fixed)
RESOLVED
FIXED
mozilla34
Tracking | Status | |
---|---|---|
firefox31 | --- | unaffected |
firefox32 | --- | unaffected |
firefox33 | --- | fixed |
firefox34 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
akachkach
:
review+
|
Details | Diff | Splinter Review |
Those are regressions from bug 886570.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ac9f5bfcb788
Assignee | ||
Comment 3•10 years ago
|
||
Sorry. https://tbpl.mozilla.org/?tree=Try&rev=f4b7fe55d07e
Attachment #8471513 -
Attachment is obsolete: true
Attachment #8471513 -
Flags: review?(akachkach)
Attachment #8471520 -
Flags: review?(akachkach)
Assignee | ||
Comment 4•10 years ago
|
||
The one leak we see so far is reproducible locally for me: toolkit/mozapps/extensions/test/browser/browser_openH264.js | leaked 2 window(s) until shutdown [url = about:addons]
Assignee | ||
Comment 5•10 years ago
|
||
Try push with a fix for bug 1052409: https://tbpl.mozilla.org/?tree=Try&rev=e1d01b882103
Comment 6•10 years ago
|
||
Comment on attachment 8471520 [details] [diff] [review] 0001-Bug-1052371-Fix-m-bc-shutdown-leak-detector.patch, v2 Review of attachment 8471520 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! The "suite_end" part is probably due to the fact that we don't process the messages generated through Python by those handlers (and that was previously generated by the JS side). I went ahead and checked that "TEST-START | Shutdown" is still printed by mochitest-plain, mochitest-chrome and robocop.
Attachment #8471520 -
Flags: review?(akachkach) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d04a9bf0df24
Assignee | ||
Comment 8•10 years ago
|
||
Oops, Android mochitests were failing. Pushed a tiny bustage fix: https://hg.mozilla.org/integration/fx-team/rev/9b26ce378971
Assignee | ||
Comment 9•10 years ago
|
||
Had to back out unfortunately. DevTools tests leak the world :( https://hg.mozilla.org/integration/fx-team/rev/e5249cb294a8 https://hg.mozilla.org/integration/fx-team/rev/a60a276fb205
Assignee | ||
Comment 10•10 years ago
|
||
Here is a leak log: https://tbpl.mozilla.org/php/getParsedLog.php?id=45772397&tree=Fx-Team
Assignee | ||
Comment 11•10 years ago
|
||
New try push with the patch from bug 1052756: https://tbpl.mozilla.org/?tree=Try&rev=469635719a6b
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c865443dfb0c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•