Closed Bug 1052538 Opened 10 years ago Closed 10 years ago

Twitter overrides/blocks find, undo close & new tab/window, and other browser keyboard shortcuts (Ctrl+F, Ctrl+T/N, Ctrl+Shift+T/N, Ctrl+L/K, Ctrl+Shift+J/K, & etc.)

Categories

(Tech Evangelism Graveyard :: English US, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davemgarrett, Unassigned)

References

()

Details

Ctrl+F, Ctrl+Shift+J, & etc. don't work on Twitter anymore. A page to test on: https://twitter.com/mozilla Their override of the find shortcut doesn't even do anything. They also override ALL usage of the 'J' key to scroll down, even if modifiers are used. They have other shortcuts on modifierless keys as well. Apparently 'U' mutes, so I accidentally muted @Mozilla when I was testing to see what the upwards counterpart to 'J' was. These keyboard shortcuts were made by an idiot. Filing as a TE bug because bug 380637 exists and is in desperate need of fixing. In the meantime, can someone contact Twitter and get them to not do stuff like this? At a bare minimum, nothing should be blocking keyboard shortcuts it doesn't even use. Overriding Ctrl+F to force users to use an in-site search would be bad, but overriding it to do nothing is just broken. Note that opening up the find bar via menu instead of shortcut or via shortcut with the address bar focused still works and F3 & Shift+F3 still work everywhere.
To be clear, "& etc." appears to be nearly everything. I can't do Ctrl+L then Ctrl+F to work around this, as Ctrl+L is also blocked and does nothing.
Summary: Twitter blocks find and other browser keyboard shortcuts (Ctrl+F, Ctrl+Shift+J, & etc.) → Twitter blocks find and other browser keyboard shortcuts (Ctrl+F, Ctrl+L, Ctrl+Shift+J, & etc.)
It looks like a list of common shortcuts are allowed, but it's blocking ones it doesn't know about. A short list of working ones: (Shift+)Ctrl+Tab, PageUp/Down, arrow keys, Ctrl+Z/X/C/V, Ctrl+S, Ctrl+W, (Shift+)Ctrl+N/T, Ctrl+K like Ctrl+L is also broken. Apparently 'K' is the counterpart to 'J' on Twitter.
Per bug 1052548, Ctrl+R is also broken, however (Ctrl+)F5 still works fine.
(In reply to Dave Garrett from comment #2) > (Shift+)Ctrl+N/T, I could've sworn those where working, but apparently not. (or this changed in the last 15 minutes?)
I am seeing the same behavior on OS X with regards to the ⌘-key combinations listed above, so it’s not a single-platform issue. I am not seeing this behavior on other sites which also have keyboard shortcuts, such as Flickr. The behavior doesn’t happen with 100% reproducibility—maybe only 90%. If a tweet is focused, then the keyboard key does whatever the Twitter keyboard shortcut should do. For example, if I hit ⌘-T to open a new tab, I get the Twitter retweet dialog instead. Similarly, ⌘-N opens a Twitter “New tweet” dialog but does not spawn a new window. However, this isn’t consistent for all keyboard shortcuts. Sometimes, ⌘-R opens a Twitter reply box and sometimes it doesn’t, but it never actually reloads the page while on Twitter. I can also see the appropriate menubar Firefox entry light up in relevant cases; for example, if I hit ⌘-T, the “File” menubar entry highlights. And yet, I get the retweet dialog and no new tab. Ditto “New Window”.
(In reply to Eric A. Meyer from comment #6) > it’s not a single-platform issue I neglected to mention it above, but I tested in a new profile under stable & nightly in Linux & Windows. (as I usually do) Thanks for reporting the status on Mac, as well.
Yeah, I just hit cmd-u to view source and find the offending code but that just muted someone. :/
For the record, no errors appear in the Browser Error Console (Ctrl+Shift+J) or the Web Error Console (Ctrl+Shift+K, also broken). (In reply to Mike Taylor [:miketaylr] from comment #8) > Yeah, I just hit cmd-u to view source and find the offending code but that > just muted someone. :/ Checking source via the context menu and searching in there shows some ugly minified JS listening to ["click","keydown","keypress","keyup"] in <script id="swift_action_queue">.
Summary: Twitter blocks find and other browser keyboard shortcuts (Ctrl+F, Ctrl+L, Ctrl+Shift+J, & etc.) → Twitter overrides/blocks find, undo close & new tab/window, and other browser keyboard shortcuts (Ctrl+F, Ctrl+T/N, Ctrl+Shift+T/N, Ctrl+L/K, Ctrl+Shift+J/K, & etc.)
My friend at twitter says the fix is scheduled to be deployed tomorrow.
Confirmed that we are working on this and should get the fix out shortly - I've linked to this bug on our internal tracker too (@andypiper @TwitterDev)
This is fixed now. Thanks Andy and the rest of the web team at Twitter. :)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Tech Evangelism → Tech Evangelism Graveyard
@miketaylr This symptom appears to have re-appeared. In FF 51.0a2, Ctrl-F's a no-go on Twitter properties. Chat in #firefox suggests similar problems with 50.0b8, at least ... Same issue, and reopen this? Or new issue?
Flags: needinfo?(miket)
Whoops, missed this ni? A new issue would probably be best if it still reproduces (it doesn't for me).
Flags: needinfo?(miket)
You need to log in before you can comment on or make changes to this bug.