Closed
Bug 1052633
Opened 10 years ago
Closed 10 years ago
Add infrastructure for SDK tests to fail on uncaught promise rejections
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
This adds everything needed to throw during unhandled promise rejections (just need to uncomment out the line in unit-test), and changes `Promise` from sdk/core/promise to be from Promise.jsm, rather than DOM promises, for error handling.
Attachment #8471783 -
Flags: review?(evold)
|
||
Updated•10 years ago
|
Attachment #8471783 -
Flags: review?(evold) → review+
|
||
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/2762109bbe7618bb409b1fd19c5794dc7509cdbb
Bug 1052633 - Add infrastructure to throw on uncaught promise rejections during tests
https://github.com/mozilla/addon-sdk/commit/cf957eb211a87a044930e0731ad36cc7b1228a49
Merge pull request #1580 from jsantell/1052633
bug 1052633 - add infrastructure to throw on uncaught promise rejections, r=@erikvold
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•