Closed
Bug 1053067
Opened 10 years ago
Closed 10 years ago
Correct misspelling "verion" in source code
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: emorley, Assigned: vikrantsingh.it)
References
Details
(Whiteboard: [good first bug])
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
Broken out from bug 577266 just so we can close that bug out. In quite a few places "version" is spelt as "verion": http://mxr.mozilla.org/mozilla-central/search?string=verion Some of these places are in upstream projects (files under /security/nss/ and /media/webrtc/signaling/src/sipcc/), so will need fixing upstream separately. Marking this a good first bug.
Assignee | ||
Comment 5•10 years ago
|
||
just to make sure, also did grep to find 'verion', and not result found except patch file
Reporter | ||
Comment 6•10 years ago
|
||
Thank you for the patch - some of the changes touch files that need to be fixed upstream (see comment 0), so are likely best separated out. I'd suggest: * Patch for the mach change * Patch for the webrtc change (with review requested from :jesup, since I'm not sure which files are from upstream and so not supposed to be modified) * Perhaps filing a separate bug for the NSS changes, since they will likely take a lot longer (and need to be landed in a separate repository), here: https://bugzilla.mozilla.org/enter_bug.cgi?product=NSS&component=Test
Assignee | ||
Comment 7•10 years ago
|
||
Patch for the mach change
Attachment #8473666 -
Attachment is obsolete: true
Assignee | ||
Comment 8•10 years ago
|
||
Patch for the webrtc change
Attachment #8474077 -
Flags: review?(rjesup)
Assignee | ||
Comment 9•10 years ago
|
||
For NSS change new Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1054625 created. Also posted patch there.
Reporter | ||
Comment 10•10 years ago
|
||
Comment on attachment 8474076 [details] [diff] [review] mach_version_spelling_correction.patch These look great - thank you for breaking the NSS one out :-) :jesup will need to say whether the sipcc changes need to go upstream or not.
Attachment #8474076 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
@Ed Morley, Thanks for reviewing patch. May I know what is next step ? should I checkin the mach_version_spelling_correction.patch or wait till review of webrtc_version_spelling_correction.patch and checkin both together?
Status: NEW → ASSIGNED
Comment 12•10 years ago
|
||
Comment on attachment 8474077 [details] [diff] [review] webrtc_version_spelling_correction.patch Review of attachment 8474077 [details] [diff] [review]: ----------------------------------------------------------------- r+; and there's no upstreaming of suipcc fixes so this can just land
Attachment #8474077 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [good first bug] → [good first bug] [checkin-needed]
Reporter | ||
Comment 13•10 years ago
|
||
The two patches here have been landed on mozilla-inbound, and will be merged to mozilla-central later today (at which point this bug will be marked resolved fixed). https://hg.mozilla.org/integration/mozilla-inbound/rev/e0258a0ba700 https://hg.mozilla.org/integration/mozilla-inbound/rev/746b2e3a88c5 Thank you for the patches! :-)
Whiteboard: [good first bug] [checkin-needed] → [good first bug]
Reporter | ||
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0258a0ba700 https://hg.mozilla.org/mozilla-central/rev/746b2e3a88c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•