Closed
Bug 1053136
Opened 10 years ago
Closed 10 years ago
[SMS]Moz10n issues in SMS app
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Firefox OS Graveyard
Gaia::SMS
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1040271
People
(Reporter: ankit93040, Unassigned)
Details
(Whiteboard: [g+][LibGLA, Dev, B] )
Attachments
(3 files, 1 obsolete file)
|
(deleted),
image/jpeg
|
Details | |
|
(deleted),
image/jpeg
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
1.jpg
User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36
Steps to reproduce:
2 instances are there -
Instance 1:-
1. Message->New message->send a message
2. Long Click on the text -> options are shown
3. Press home button
4. Settings->Language->change language
5. Press home button
6. Go to message (see the attachment 1 [details] [diff] [review])
Instance 2:-
1. Message->New Message
2. options -> options are shown
3. Press home button
4. Settings->Language->change language
5. Press home button
6. Go to message (see the attachment 2 [details] [diff] [review])
Actual results:
Mozl10n is not properly localized
Expected results:
Mozl10n should be properly localized
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(felash)
Whiteboard: [g+][LibGLA, Dev, B]
|
|
Reporter | |
Comment 1•10 years ago
|
||
|
|
Reporter | |
Comment 2•10 years ago
|
||
|
|
Reporter | |
Updated•10 years ago
|
Component: General → Gaia::SMS
|
||
Comment 3•10 years ago
|
||
I'm quite sure instance 2 will be fixed by bug 1040271.
Not sure for instance 1.
Can you please try with the patch in bug 1040271?
Flags: needinfo?(felash)
|
|
Reporter | |
Comment 4•10 years ago
|
||
Hi Julien
Both the instances are resolved with these.
uploading the copied patch from https://github.com/mozilla-b2g/gaia/pull/21941/files which resolves this issue.
When is this patch going to land?
Flags: needinfo?(felash)
|
|
Reporter | |
Comment 5•10 years ago
|
||
|
|
||
Comment 6•10 years ago
|
||
Should land soon;
Thanks for testing!
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(felash)
Resolution: --- → DUPLICATE
|
|
Reporter | |
Comment 7•10 years ago
|
||
Hi Julienw
If https://bugzilla.mozilla.org/show_bug.cgi?id=1040271#c23 these can't be uplifted, can these issue be resolved by this patch(attached). Modified patch from 1040271 to resolve this issue.
If that can be uplifted then all's well.
Please review the patch if you are not uplifting.
Thanks!
|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(felash)
|
|
Reporter | |
Comment 8•10 years ago
|
||
Attachment #8472792 -
Attachment is obsolete: true
|
|
||
Comment 9•10 years ago
|
||
I think it should work fine but be careful to fix any test that fails because of these changes.
Flags: needinfo?(felash)
You need to log in
before you can comment on or make changes to this bug.
Description
•