Closed Bug 1053407 Opened 10 years ago Closed 10 years ago

Convert PeerConnections's RTCError into DOMError and stop using __exposedProps__

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jib, Assigned: jib)

Details

Attachments

(1 file)

Opening this bug in response to: (In reply to Olli Pettay [:smaug] from Bug 1032839 comment #4) > Do we have a bug filed to convert RTCError to something sane. > (Use of __exposedProps__ is scary.) This refers to RTCError in PeerConnection.js: http://mxr.mozilla.org/mozilla-central/source/dom/media/PeerConnection.js#969 Actually, the spec calls for us to return DOMError as an argument to callbacks: http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtcpeerconnectionerrorcallback The spec then has this note http://dev.w3.org/2011/webrtc/editor/webrtc.html#attributes-1 : > Ask the DOM team to extend their list with the following errors. > InvalidSessionDescriptionError > IncompatibleSessionDescriptionError > IncompatibleConstraintsError > IncompatibleMediaStreamTrackError > InternalError So it seems we are blocked on some extensions to DOMError or some discussion about this use of DOMError, as well as the outcome of DOMError (is it turning into DOMException?) - It seems weird to be creating and returning instances of DOMException as callback arguments rather than throwing them. For now, an improvement to the current __exposedProps__ code might be to make a temporary webidl-class that perhaps even inherits from DOMError and extends it? I think we're open to ideas.
Moved Part 1 from Bug 1091898 comment 48 here. Carrying forward r=bz (on irc), r=jesup.
Attachment #8532731 - Flags: review+
Summary: Convert PeerConnections's RTCError into DOMError (or at least don't use __exposedProps__) → Convert PeerConnections's RTCError into DOMError and stop using __exposedProps__
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: