Closed
Bug 1053674
Opened 10 years ago
Closed 10 years ago
Remove subclass of StateMachine and use task queue directly
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: kinetik, Assigned: kinetik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Rather than have an ugly subclass of MediaDecoderStateMachine just to get a reference to the reader and task queue, give MediaSourceReader its own task queue (from the same pool as the queue we were using).
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8472844 -
Flags: review?(cpearce)
Updated•10 years ago
|
Attachment #8472844 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/012b4107cfa0
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8473524 -
Flags: review?(cpearce)
Comment 4•10 years ago
|
||
Backed out for mochitest-1 and crashtest bustage https://hg.mozilla.org/integration/mozilla-inbound/rev/a7d98b35305f
Comment 5•10 years ago
|
||
Comment on attachment 8473524 [details] [diff] [review] Shut down MSR task queue. Review of attachment 8473524 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/mediasource/MediaSourceReader.cpp @@ +46,5 @@ > } > > +MediaSourceReader::~MediaSourceReader() > +{ > + mTaskQueue->Shutdown(); Do this at the end of your MediaDecoderReader::Shutdown() override. Funny, I had wondered if this would be a problem with your previous patch, but I figured since your Shutdown() override already called Shutdown() on the subreaders, it would be ok. Guess not.. :P
Attachment #8473524 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f59a9eb1658
Assignee | ||
Comment 7•10 years ago
|
||
And backed out again: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bde32496fa3 Due to bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=46144803&tree=Mozilla-Inbound#error0
Assignee | ||
Updated•10 years ago
|
Attachment #8473524 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8472844 -
Attachment is obsolete: true
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8474373 -
Flags: review?(cpearce)
Assignee | ||
Updated•10 years ago
|
Summary: Remove subclass of StateMachine and use our own task queue. → Remove subclass of StateMachine and use task queue directly
Assignee | ||
Comment 9•10 years ago
|
||
Simpler approach: use the existing task queue directly, rather than going via MDSM.
Updated•10 years ago
|
Attachment #8474373 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65c3554ccc07
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65c3554ccc07
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Assignee | ||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•