Closed
Bug 1053676
Opened 10 years ago
Closed 10 years ago
Assertion failure: [barrier verifier] Unmarked edge: <unknown>, at gc/Verifier.cpp
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
firefox33 | --- | disabled |
firefox34 | --- | disabled |
firefox35 | --- | verified |
firefox-esr31 | --- | unaffected |
People
(Reporter: gkw, Assigned: jorendorff)
References
Details
(5 keywords, Whiteboard: [jsbugmon:update])
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
var x
(function() {
x
}());
verifyprebarriers();
x = x * 0
x = Symbol();
gc();
evalcx("x=1", this);
asserts js debug shell on m-c changeset d7e78f0c1465 with --ion-offthread-compile=off --ion-eager --no-threads at Assertion failure: [barrier verifier] Unmarked edge: <unknown>, at gc/Verifier.cpp
My configure flags are:
CC="clang -Qunused-arguments" CXX="clang++ -Qunused-arguments" AR=ar sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin12.5.0 --enable-debug --enable-optimize --enable-gczeal --enable-debug-symbols --disable-tests --enable-more-deterministic --with-ccache --enable-nspr-build
autoBisect shows this is probably related to the following changeset:
The first bad revision is:
changeset: https://hg.mozilla.org/mozilla-central/rev/82afa573b285
user: Jason Orendorff
date: Mon Jun 23 10:56:49 2014 -0500
summary: Bug 645416, part 9 - Implement the symbol registry and Symbol.for(). r=terrence,r=efaust.
Setting s-s and assuming sec-critical because this involves gc.
Jason, is bug 645416 a likely regressor?
Flags: needinfo?(jorendorff)
Reporter | ||
Updated•10 years ago
|
status-firefox34:
--- → affected
Reporter | ||
Comment 1•10 years ago
|
||
For now, Symbols are nightly-only.
status-firefox32:
--- → unaffected
status-firefox33:
--- → unaffected
status-firefox35:
--- → affected
status-firefox-esr31:
--- → unaffected
Reporter | ||
Comment 2•10 years ago
|
||
Switching flags to disabled. (plus Symbols only landed and in disabled form from Fx33)
Assignee | ||
Comment 3•10 years ago
|
||
Actually just about every hunk of this patch is there for a different reason, but I think it should be pretty self-explanatory.
Attachment #8489529 -
Flags: review?(terrence)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8489529 [details] [diff] [review]
Insert GC pre-barriers for slots containing symbols in Ion code
Review of attachment 8489529 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8489529 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Comment 8•10 years ago
|
||
JSBugMon: This bug has been automatically verified fixed.
Updated•10 years ago
|
Group: core-security, javascript-core-security
Updated•10 years ago
|
status-firefox-esr31:
--- → unaffected
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(jorendorff)
You need to log in
before you can comment on or make changes to this bug.
Description
•