TEST-UNEXPECTED-FAIL | places/main.test bookmark-item-changed | There was an uncaught Promise rejection: JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/GZ/GZWmWAmsFyCgFUys0mXcyU+++-k/-Tmp-/tmpa56sGy.mozrunner/extensions/test-places@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/places/host/host-bookmarks.js :: createBoo... [exceeded max length]

TEST-PASS | places/main.test bookmark-item-changed | correct id in bookmark-item-changed event TEST-PASS | places/main.test bookmark-item-changed | correct data in bookmark-added event TEST-UNEXPECTED-FAIL | places/main.test bookmark-item-changed | There was an uncaught Promise rejection: JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/lk/fy5m6v752zvfl68x4hdxmdmc00000w/T/tmphoTdEQ.mozrunner/extensions/test-places@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/places/host/host-bookmarks.js :: createBookmarkItem :: line 93 JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/lk/fy5m6v752zvfl68x4hdxmdmc00000w/T/tmphoTdEQ.mozrunner/extensions/test-places@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/core/promise.js :: execute :: line 37 JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 866 JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 745 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 TEST-INFO | Traceback (most recent call last): File "resource://gre/components/nsPlacesExpiration.js", line 677, in PEX_handleCompletion Services.obs.notifyObservers(null, TOPIC_EXPIRATION_FINISHED, null); File "resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/system/events.js", line 72, in Observer<.observe this.listener({ File "resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/test.js", line 69, in null options.done(); File "resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 306, in done PromiseDebugging.flushUncaughtErrors(); File "resource://gre/modules/Promise-backend.js", line 612, in Promise.Debugging.flushUncaughtErrors PendingErrors.flush(); File "resource://gre/modules/Promise-backend.js", line 214, in PendingErrors.flush this.report(key); File "resource://gre/modules/Promise-backend.js", line 202, in PendingErrors.report obs(value); File "resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 61, in TestRunner.prototype._uncaughtErrorObserver this.fail("There was an uncaught Promise rejection: " + stack); File "resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 92, in fail this.console.testMessage(false, false, this.test.name, message); File "resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/test/harness.js", line 527, in testMessage this.trace(); TEST-END | places/main.test bookmark-item-changed

Comment on attachment 8473051 [details] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1584 Looks good -- made bug 1054080 for this same thing, but didn't see this, this is from mainly the event that's being handled in this test is fired synchronously from the platform's observer as soon as the bookmark is created, the test goes through its assertions, and then that's when the bmsrv.getItemLastModified is checked, after the test is already finished. Might be worth checking out

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/db5b0f0c4e066e6801e74253b709a13a89c23fac Bug 1053809 - places/main.test bookmark-item-changed | There was an uncaught Promise rejection https://github.com/mozilla/addon-sdk/commit/fde461f23a42a1bec0c30648cde54db80f142bc9 Merge pull request #1584 from erikvold/1053809 Bug 1053809 - places/main.test bookmark-item-changed | There was an uncaught Promise rejection. r=jsantell