Closed
Bug 1053997
Opened 10 years ago
Closed 10 years ago
reduce crash potential in our e10s test addons
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(e10s+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: zombie, Assigned: zombie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
in bug 1050391, we might be inviting too much trouble for ourself, running e10s tests in an unsupported way: starting without .autostart enabled, opening an e10s window before each test, and closing it after, which probably stress-tests the still unreliable e10s code in platform (not SDK code).
a better procedure in e10s test addons might be:
1) close the non-e10s window
2) open an e10s window
3) run the tests
4) restore starting position on unload
bonus step (belt and suspenders):
5) verify/restore starting position in Dave's changed test-runner between addon uninstall/install..
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Attachment #8473318 -
Flags: review?(dtownsend+bugmail)
Comment 2•10 years ago
|
||
Comment on attachment 8473318 [details]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1586
Up to you if you want to keep all the tests running to see how they fare on tbpl
Attachment #8473318 -
Flags: review?(dtownsend+bugmail) → review+
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/3360de7267ce2a7f859787287873ecb2d824cc93
bug 1053997 - reduce e10s crash potential
https://github.com/mozilla/addon-sdk/commit/e5a54f89076a1bb08f1c10a7d96f4bfff5d59ca6
Merge pull request #1586 from zombie/1053997-e10s-crashes
bug 1053997 - reduce e10s crash potential, r=@Mossop
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #2)
> Up to you if you want to keep all the tests running to see how they fare on tbpl
i know how they would fare: they would fail (spectacularly), because of rejected promises in tabbrowser.xml.
i figure getting to the green tree is more important ATM.
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Updated•10 years ago
|
No longer blocks: e10s-tests
Updated•10 years ago
|
Blocks: e10s-harness
Something landed in here, can we close this bug or is there more to do here?
Flags: needinfo?(tomica+amo)
Assignee | ||
Comment 6•10 years ago
|
||
yup
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(tomica+amo)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•