Probably since either bugs 1023947 or 1027713, fails with: /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:345:1: error: redefinition of 'sndio_stream_set_volume' sndio_stream_set_volume(cubeb_stream * stm, float panning) ^ /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:326:1: note: previous definition is here sndio_stream_set_volume(cubeb_stream *s, float volume) ^ /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:364:25: error: use of undeclared identifier 'sndio_stream_set_panning'; did you mean 'cubeb_stream_set_panning'? .stream_set_panning = sndio_stream_set_panning, ^~~~~~~~~~~~~~~~~~~~~~~~ cubeb_stream_set_panning ../../../dist/include/cubeb/cubeb.h:297:5: note: 'cubeb_stream_set_panning' declared here int cubeb_stream_set_panning(cubeb_stream * stream, float panning); ^ 2 warnings and 2 errors generated. /src/mozilla-central/config/rules.mk:916: recipe for target 'cubeb_sndio.o' failed Obvious fix i'm trying here: rename the duplicate set_volume implem added in https://hg.mozilla.org/mozilla-central/diff/bf4ed2946c45/media/libcubeb/src/cubeb_sndio.c by a set_panning definition, modeled after dumb other implems. Right now, dunno what panning does nor how to implement a proper thing for it with sndio. Note that the get_current_device/device_destroy/register_device_changed_callback *could* be implemented with sndio, i'll refer to ratchov for that. Right now i only need to get my builds greener.

results of build fixture in a few..

I still get some warnings from clang : /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:120:9: warning: variable 'state' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (revents & POLLHUP) ^~~~~~~~~~~~~~~~~ /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:136:26: note: uninitialized use occurs here s->state_cb(s, s->arg, state); ^~~~~ /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:120:5: note: remove the 'if' if its condition is always false if (revents & POLLHUP) ^~~~~~~~~~~~~~~~~~~~~~ /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:70:30: note: initialize the variable 'state' to silence this warning int n, nfds, revents, state; ^ = 0 /src/mozilla-central/media/libcubeb/src/cubeb_sndio.c:274:14: warning: incompatible integer to pointer conversion assigning to 'uint32_t *' (aka 'unsigned int *') from 'i nt' [-Wint-conversion] latency_ms = 40; which could be fixed by a followup patch - but at least build goes further than sndio, so the dumb patch fixes the build for me.

Comment on attachment 8473534 [details] [diff] [review] fix-sndio-after-1027713 Review of attachment 8473534 [details] [diff] [review]: ----------------------------------------------------------------- Those warnings look bad, definitely need to be investigated.

This fixes the warnings, and actually fixes a real bug where an integer was assigned to a pointer...

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b83d221b3d3 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e3389bb8455

https://hg.mozilla.org/mozilla-central/rev/0b83d221b3d3 https://hg.mozilla.org/mozilla-central/rev/1e3389bb8455