There will be a setting toggle to let user choose between 12/24 hour time format in v2.1. User story and settings spec: Bug 903683 For each app, the tasks to do after toggle is added would be: 1.Read/listen to the time format toggle value/change event. 2.Input the corresponding time format to existing mozL10n.DateTimeFormat() function. Currently the input time format should be a fixed 12 hour shortTimeFormat = %I:%M %p , line 201 of http://goo.gl/DR4CNe. There will be a 24 hour time format added. 3.Show the return of the function as it's doing now.

Hi Harly, Could you help to review the patch? Thanks.

Comment on attachment 8475753 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23063 Nicely done, thank you Evan!

Thanks for the review, Harly. The ui-review+ patch: https://github.com/evanxd/gaia/commit/ece910278001bccf2be9a6c27acfbcbf17e8d274

Comment on attachment 8475753 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23063 Hi Miller, Could you help to review the patch? And I will add/fix the tests later. Thanks.

Confirmed with EM/EPM, and this can be landed before FL.

Hi Miller, I already updated the patch for the comments. Could you help to review it? Thanks.

Comment on attachment 8475753 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23063 good work

Waiting for try server result.

The failures of the CI result[1] is not related with this patch. The failures already happened in the current master branch[2]. [1] https://tbpl.mozilla.org/?rev=51d6b6ecdabf434a7632269a0a0db6568347d30a&tree=Gaia-Try [2] https://tbpl.mozilla.org/?rev=2630942878d87fdf06983b9883b0fc0af23f4180&tree=Gaia-Try

Hi Dylan, Tree is closed now. We could land this patch once tree reopens, or we should land it now? If we would like to land it now, could you help to land it. I have no permission to do that. Thanks.

Tree is reopened now. :D

The failures of the CI result[1] is not related with this patch. The failures already happened in the current master branch[2]. And we could fix them in other patch. So let's land the code. :D [1] https://tbpl.mozilla.org/?rev=590ced5e5875&tree=Gaia-Try [2] https://tbpl.mozilla.org/?rev=b50946fac9245b04877d9065c1135cdd84f5c608&tree=Gaia-Try

Thanks Miller's review. master: https://github.com/mozilla-b2g/gaia/commit/5fa8e0878ec4d2a8a120c2b1345056e879bf51a1

[Environment] Gaia fbb297c39aab5f17b179533d2a9a6c5166b2c197 Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e796da813 BuildID 20140902160204 Version 34.0a2 ro.build.version.incremental=eng.cltbld.20140820.195518 ro.build.date=Wed Aug 20 19:55:28 EDT 2014 [Result] PASS