Closed Bug 1054185 Opened 10 years ago Closed 10 years ago

"Default" is missing from SIM picker

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.0 unaffected, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S3 (29aug)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- verified

People

(Reporter: ericcc, Assigned: drs)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Fix "Default" being missing from SIM picker.
(deleted), patch
rik
: review+
Details | Diff | Splinter Review
Video_Flame v2.1.MP4
(deleted), video/mp4
Details
### STR 1. DSDS phone with 2 SIMs, and default is set in "Settings" -> "Sim manager" 2. Have a number in call log. 3. Long tap on that number in call log. 4. Choose "Send Message". 5. Type something and long tap the "Send" button to bring up the "Select SIM" page. ### Actual v2.1-Messages-SelectSIM_fromCalllog.png "SIM1", "SIM2" Shown. ### Expected "SIM1 (default)", "SIM2" Shown. ### Version Gaia c7f8938522a18454809fb6ea0fd3eddef10a73ea Gecko https://hg.mozilla.org/mozilla-central/rev/9eb591a1a203 BuildID 20140814160206 Version 34.0a1 ro.build.version.incremental=110 ro.build.date=Fri Jun 27 15:57:58 CST 2014 B1TC00011230
https://www.youtube.com/watch?v=nM9-bBMbhDg&index=1 Hi Julien, Could you help with this, also we need to change "SIM1" to "SIM 1" right, I will file another bug for that, thanks.
QA Whiteboard: [COM=Gaia::SMS]
Flags: needinfo?(felash)
[Blocking Requested - why for this release]: 1. Regression. 2. Label missing causes confusion of default.
blocking-b2g: --- → 2.1?
Interesting one. Eric, does it still work as expected when using the "send sms" button in the Contacts app? If yes, then it's not a regression since the "longpress" menu in the call log is new in v2.1.
Flags: needinfo?(felash) → needinfo?(echang)
When using the "send sms" button in the Contacts app, it still shows 'SIM 1', 'SIM 2', no trailing 'default' after any of each. It has 'default' in v2.0.
Flags: needinfo?(echang)
Thanks, then using the Contacts app is a better STR to find the regression window, because the STR using the call log might lead to the commit implementing the menu for the call log. QA, please use STR in comment 3 to find the regression window.
QA Contact: pcheng
I found that this issue only reproduces on the 1st attempt. All subsequent attempts will successfully bring up the SIM selection menu with a '(default)' labeled. To repro the bug again the user will have to kill the app and launch it again. b2g-inbound regression window: Last Working Environmental Variables: Device: Flame BuildID: 20140721120230 Gaia: 265bcc8bd54f9da013ff67e1f5826ccfb84df1de Gecko: 31e1810ef190 Version: 33.0a1 (2.1 Master) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 First Broken Environmental Variables: Device: Flame Gaia: 8d13375b488852bf593b0a6dd0ba90ecf4ee5d43 Gecko: d39392d425a3 Version: 33.0a1 (2.1 Master) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 First broken gecko & last working gaia - issue does NOT repro Gaia: 265bcc8bd54f9da013ff67e1f5826ccfb84df1de Gecko: d39392d425a3 First broken gaia & last working gecko - issue DOES repro Gaia: 8d13375b488852bf593b0a6dd0ba90ecf4ee5d43 Gecko: 31e1810ef190 Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/265bcc8bd54f9da013ff67e1f5826ccfb84df1de...8d13375b488852bf593b0a6dd0ba90ecf4ee5d43 Caused by Bug 1037637.
QA Whiteboard: [COM=Gaia::SMS] → [COM=Gaia::SMS][QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: regressionwindow-wanted
Broken by bug 1037637 ?
Blocks: 1037637
QA Whiteboard: [COM=Gaia::SMS][QAnalyst-Triage?] → [COM=Gaia::SMS][QAnalyst-Triage+]
Flags: needinfo?(jmitchell) → needinfo?(gandalf)
Flags: needinfo?(drs+bugzilla)
Eric, actually, I've seen this also when just launching the application.
I noticed this as well and it will be fixed accidentally in bug 1045820. I believe that it will land before FC so we could just dupe this to that. But I'll look into this anyways as I'd like to know why exactly it's happening.
Assignee: nobody → drs+bugzilla
Attached patch Fix "Default" being missing from SIM picker. (obsolete) (deleted) — — Splinter Review
PR: https://github.com/mozilla-b2g/gaia/pull/23042
Attachment #8475300 - Flags: review?(anthony)
Flags: needinfo?(gandalf)
Flags: needinfo?(drs+bugzilla)
Status: NEW → ASSIGNED
Component: Gaia::SMS → Gaia::Dialer
Summary: [Messages][SMS] "Default" is missing Select SIM page when sending messages from call log → "Default" is missing from SIM picker
Target Milestone: --- → 2.1 S3 (29aug)
QA Whiteboard: [COM=Gaia::SMS][QAnalyst-Triage+] → [COM=Gaia::SMS][QAnalyst-Triage+][lead-review+]
Yes, just tried that, reproducible... (In reply to Julien Wajsberg [:julienw] (PTO 08/19 -> 09/15; contact schung for SMS matters) from comment #8) > Eric, actually, I've seen this also when just launching the application.
Comment on attachment 8475300 [details] [diff] [review] Fix "Default" being missing from SIM picker. Review of attachment 8475300 [details] [diff] [review]: ----------------------------------------------------------------- This needs a new test.
Attachment #8475300 - Flags: review?(anthony) → review-
Updated PR. The test "SIM picker buttons should mark default SIM" fails without the changes to sim_picker.js.
Attachment #8475300 - Attachment is obsolete: true
Attachment #8478374 - Flags: review?(anthony)
Attachment #8478374 - Flags: review?(anthony) → review+
https://github.com/mozilla-b2g/gaia/commit/2b8d7ccb77565440b3edb0f56e91bd1f60a83196
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: affected → fixed
Resolution: --- → FIXED
Switching the 2.1?->2.1+, on these fixed bugs as these are regression. Nothing to land here, its just flag-cleanup of 2.1? list. Please Ni me if there is confusion/disagreement.
blocking-b2g: 2.1? → 2.1+
Gaia-Rev b542080231bb9cdbdb282ab926965ad3f91f7460 Gecko-Rev https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03 Build-ID 20140923155123 Version 34.0a2 Device-Name flame FW-Release 4.4.2 FW-Incremental 27 FW-Date Thu Sep 4 14:59:02 CST 2014 Bootloader L1TC10011800
Status: RESOLVED → VERIFIED
Attached video Video_Flame v2.1.MP4 (deleted) —
This issue doesn't exist on the Flame v2.1. Occurrence rate: 0/20 Flame v2.1 version: Gaia-Rev afdfa629be209dd53a1b7b6d6c95eab7077ffcd9 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6 Build-ID 20141123001201 Version 34.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: