Closed Bug 1054230 Opened 10 years ago Closed 10 years ago

[RTSP] Potential crash happens if decode error when reading meta data

Categories

(Firefox OS Graveyard :: RTSP, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1049241
2.1 S4 (12sep)

People

(Reporter: ethan, Assigned: ethan)

Details

(Whiteboard: [p=1])

Attachments

(1 file)

This bug is found while debugging bug 1049241. By playing the particular link "rtsp://125.141.31.147:554/QE/Coverage20130826/R006_3GP_H.263(qCIF@541Kbps@15fps)_AAC-LC(96Kbps@22.05kHz@2ch).3gp", there are two possible results: 1. The video cannot be played and an error message is shown: "Video can't be played because the file if corrupt." 2. System crash. In this case, the crash caused in an assertion in AMPEG4AudioAssembler.cpp.
Attached file gdb_backtrace.log (deleted) —
GDB backtrace output of the crash.
The audio codec of this clip is AAC-LC (Advanced Audio Coding, Low-Complexity). For some reason (tracked by bug 1049241), OmxDecoder fails to read its audio metadata and would trigger MediaDecoder::DecodeError(), which would then shutdown the media resource. This shutdown is triggered from the content process and will be propagated to the parent process: MediaDecoder::Shutdown() -> RtspMediaResource::Close() -> RtspControllerChild::Stop() -> ... [IPC] ... -> RtspControllerParent::RecvStop() -> ... -> RTSPSource::stop() The problem is, when this shutdown is in process, the parent process could still receive and process RTP packets from the network. In this case, it is possible that AMPEG4AudioAssembler is accessing some memory that was already revoked by the shutdown procedure and caused the crash.
Assignee: nobody → ettseng
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
Target Milestone: 2.1 S2 (15aug) → 2.1 S4 (12sep)
This bug is resolved fixed by the patch of bug 1049241.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: