Closed
Bug 1054304
Opened 10 years ago
Closed 10 years ago
Mochitest's TestRunner.js logs an invalid subtest status
Categories
(Testing :: Mochitest, defect)
Tracking
(firefox33 fixed, firefox34 fixed)
RESOLVED
FIXED
mozilla34
People
(Reporter: chmanchester, Assigned: akachkach)
References
Details
Attachments
(1 file)
(deleted),
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
TestRunner.js logs an expected subtest status of "OK" in a testStatus call when test URLs get out of sync here: http://hg.mozilla.org/mozilla-central/file/5327d2c8ee54/testing/mochitest/tests/SimpleTest/TestRunner.js#l691 "OK" isn't a valid subtest status, so an exception is thrown, see https://bugzilla.mozilla.org/show_bug.cgi?id=1050251#c9
Assignee | ||
Comment 1•10 years ago
|
||
"ERROR" also isn't a valid status. I wonder if this shouldn't be a testEnd message (as seen in bug 1051635), but maybe it's better to replace "OK" by "PASS" and "ERROR" with "FAIL" For now as the test could've been ended previously.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8473743 -
Flags: review?(cmanchester)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → akachkach
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8473743 [details] [diff] [review]
0001-Bug-1054304-correct-test-status-for-tests-that-do-no.patch
Review of attachment 8473743 [details] [diff] [review]:
-----------------------------------------------------------------
Like we talked about a bit there's a pending issue of whether this really should be a test_end, but this will fix the invalid subtest status error in the meantime.
Attachment #8473743 -
Flags: review?(cmanchester) → review+
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment 7•10 years ago
|
||
status-firefox33:
--- → fixed
status-firefox34:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•