Closed
Bug 1055150
Opened 10 years ago
Closed 10 years ago
GetContextInternal can be null when nsGlobalWindow::SetNewDocument is called
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 1031303
People
(Reporter: Mardak, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
From bug 1039881 comment 37 with bug 1039881 comment 24 providing some context for the crash.
Brief summary is it seems that creating a background thumbnail for a new tab history tile could cause SetNewDocument to crash at mContext->WillInitializeContext();
It's currently not crashing on mozilla-central, so either it's fixed elsewhere or being masked by some other changes more recent than those for mozilla-beta.
bholley suggests we can be proactively safer by landing the change we made on beta on nightly and aurora.
Comment 1•10 years ago
|
||
Dup of bug 1031303?
Reporter | ||
Comment 2•10 years ago
|
||
r=bholley from bug 1039881 comment 28
Attachment #8474674 -
Flags: review+
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #1)
> Dup of bug 1031303?
Quite possibly. I'll try to bisect around there to see if that caused the tests to no longer crash with the pref change from bug 1039881.
Reporter | ||
Comment 4•10 years ago
|
||
Thanks smaug!
tests crash:
https://tbpl.mozilla.org/?tree=Try&rev=ff7871d38d71
https://hg.mozilla.org/mozilla-central/rev/0174684f6250
Merge m-c to inbound. a=merge
tests pass:
https://tbpl.mozilla.org/?tree=Try&rev=105d98581b84
https://hg.mozilla.org/mozilla-central/rev/12b4cad8e0bc
Bug 1031303 - mContext can be null when nsGlobalWindow::SetNewDocument is called, r=jst
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•