Open
Bug 1055227
Opened 10 years ago
Updated 2 years ago
Make sandbox logging (security/sandbox/chromium/base/shim/base/logging*) actually emit log messsages.
Categories
(Core :: Security: Process Sandboxing, defect)
Tracking
()
NEW
People
(Reporter: jld, Unassigned)
References
(Blocks 2 open bugs)
Details
(Whiteboard: sb+)
Currently, the logging stubs in security/sandbox/chromium/base/shim/base/logging* just discard any messages that are logged. We should fix that so they actually send messages somewhere. This should allow removing the Linux sandbox's LOG_ERROR macro. This will be more important when the Linux sandbox uses more of the upstream Chromium code.
Most of the original Chromium logging code should be reusable here, I think.
In contrast with bug 1013988, I see no point in reintroducing NSPR dependencies here; at least on Linux platforms, NSPR logging is strictly worse than fprintf.
Updated•10 years ago
|
Comment 2•10 years ago
|
||
(In reply to Jed Davis [:jld] from comment #0)
> In contrast with bug 1013988, I see no point in reintroducing NSPR
> dependencies here; at least on Linux platforms, NSPR logging is strictly
> worse than fprintf.
Jed can you provide some more background on this? I'd like to take your needs into consideration in our logging improvement project (bug 881389).
Flags: needinfo?(jld)
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Eric Rahm [:erahm] from comment #2)
> Jed can you provide some more background on this? I'd like to take your
> needs into consideration in our logging improvement project (bug 881389).
The problems with NSPR were:
1. Can't do logging that's enabled by default without obscure env vars.
2. Can't be used in async signal context.
And at least one unwanted "feature":
3. Debug builds only by default.
The debug-only and disabled-by-default problems are problems for other users, but there's not much of our code that's (potentially) run in async signal handlers: sandboxing, the profiler, maybe some small parts of the JS engine.
Async signal safety is also a somewhat difficult requirement — we'd need to be able to supply a stack-allocated buffer, use a suitable implementation of formatted I/O (Chromium has one), and write the result with something like the write() system call (i.e., not stdio).
Flags: needinfo?(jld)
Reporter | ||
Comment 4•10 years ago
|
||
Move process sandboxing bugs to the new Bugzilla component.
(Sorry for the bugspam; filter on 3c21328c-8cfb-4819-9d88-f6e965067350.)
Component: Security → Security: Process Sandboxing
Updated•9 years ago
|
Whiteboard: sb+
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•