Closed
Bug 1055356
Opened 10 years ago
Closed 10 years ago
[SMS] Threads view Unread indicator and contact photo are not screen reader friendly
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1])
Attachments
(1 file)
I don't think they use the <aside> tag appropriately. In any case, they need to be labeled in a way that the screen reader could use.
|
Assignee | |
Updated•10 years ago
|
Component: Gaia → Gaia::SMS
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [b2ga11y p=1]
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8474918 -
Flags: review?(azasypkin)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8474918 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014
Hey Eitan,
I've left a few comments on GitHub, especially one related to thread in "draft" state that is currently broken.
Please, set r? flag again whenever you're ready and thanks for the patch!
Attachment #8474918 -
Flags: review?(azasypkin)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8474918 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014
Thanks, Oleg for the feedback.
New patch is up!
Attachment #8474918 -
Flags: review?(azasypkin)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8474918 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014
Hey Eitan, now it's good except that it still hides draft icon :)
Attachment #8474918 -
Flags: review?(azasypkin)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8474918 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014
Oops! Fixed.
Attachment #8474918 -
Flags: review?(azasypkin)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8474918 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014
Looks fine now, r=me!
Thanks!
Attachment #8474918 -
Flags: review?(azasypkin) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•