Closed
Bug 1055539
Opened 10 years ago
Closed 10 years ago
Rename TabsPanel internal class from TabsListContainer to PanelViewContainer
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
(Whiteboard: [fixed-larch])
Attachments
(1 file)
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
There are too many usages of the word tab, we should refactor this to accurately describe what it is
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8475215 -
Flags: review?(lucasr.at.mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8475215 [details] [diff] [review]
bug 1055539 - Rename TabsPanel internal class from TabsListContainer to PanelViewContainer
Review of attachment 8475215 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good with the nits fixed.
::: mobile/android/base/tabs/TabsPanel.java
@@ +251,4 @@
> return mActivity.onOptionsItemSelected(item);
> }
>
> + private static int getTabContainerHeight(PanelViewContainer listContainer) {
nits:
getTabContainerHeight -> getPanelsContainerHeight
listContainer -> panelsContainer
For consistency.
Attachment #8475215 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
oops - pushed to larch by mistake
http://hg.mozilla.org/projects/larch/rev/8db4bd78932d
Whiteboard: [fixed-larch]
|
|
Assignee | |
Comment 4•10 years ago
|
||
Backed out of larch
https://hg.mozilla.org/integration/fx-team/rev/63af113825cb
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•