Closed
Bug 1055643
Opened 10 years ago
Closed 10 years ago
System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument
Categories
(Firefox :: Sync, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ckarlof
:
review+
|
Details | Diff | Splinter Review |
I noticed this warning early on during a mochitest run:
{
12 INFO System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument
}
Relevant source code:
> 395 stripHeaderAttributes: function(value) {
> 396 let value = value || "";
http://mxr.mozilla.org/mozilla-central/source/services/crypto/modules/utils.js?rev=6e77dfcf5c6e&mark=395-396#395
We just want to drop the "let" there, I think.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Attachment #8475269 -
Flags: review?(ckarlof) → review+
|
|
||
Comment 2•10 years ago
|
||
Thanks!
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc9477045c7
Flags: in-testsuite-
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Comment 5•10 years ago
|
||
FWIW this probably bitrotted one of the patches in bug 1001090.
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•