Closed Bug 1055852 Opened 10 years ago Closed 10 years ago

sipcc leaks like a sieve

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: bwc, Assigned: bwc)

References

Details

(Whiteboard: [MemShrink])

Attachments

(3 files, 1 obsolete file)

LSAN output from SignalingTest.FullCall
(deleted), application/x-bzip2
Details
Plug bunches of leaks that signaling_unittest hits, mostly in sipcc.
(deleted), patch
mt
: review+
Details | Diff | Splinter Review
Part 2: Remove the suppressions for these leaks
(deleted), patch
bwc
: review+
Details | Diff | Splinter Review
I'm wrapping up my thread flattening patches, and tried out an LSAN run to see if I introduced any leaks. You know what it's like opening that tupperware container that has been buried at the back of your fridge for longer than you can remember? You know, that "I should not have opened that." moment? Yeah...
I think I will mark this as dependent on bug 991037 because there is at least one place where plugging the leak is much easier if we can assume that there are no async dispatches and such.
Depends on: 991037
Assignee: nobody → docfaraday
Status: NEW → ASSIGNED
Attachment #8477005 - Flags: review?(martin.thomson)
Update the suppressions file.
Fantastic!
Whiteboard: [MemShrink]
Blocks: 979928
Attachment #8477005 - Flags: review?(martin.thomson) → review+
Who should I ask to review the suppressions file?
Flags: needinfo?(continuation)
Comment on attachment 8477710 [details] [diff] [review] Part 2: Remove the suppressions for these leaks. I can just review it. You are just removing suppressions so there shouldn't be a problem. :)
Attachment #8477710 - Flags: review+
Flags: needinfo?(continuation)
No longer blocks: 1057804
Unrot.
Attachment #8477710 - Attachment is obsolete: true
Comment on attachment 8479383 [details] [diff] [review] Part 2: Remove the suppressions for these leaks Review of attachment 8479383 [details] [diff] [review]: ----------------------------------------------------------------- Carry forward r=mccr8
Attachment #8479383 - Flags: review+
Keywords: checkin-needed
seems this patch failed to apply patching file build/sanitizers/lsan_suppressions.txt Hunk #1 FAILED at 27 1 out of 1 hunks FAILED -- saving rejects to file build/sanitizers/lsan_suppressions.txt.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh remove_suppressions Byron: could you take a look and maybe rebase, thanks!
Flags: needinfo?(docfaraday)
(In reply to Carsten Book [:Tomcat] from comment #11) > seems this patch failed to apply > > patching file build/sanitizers/lsan_suppressions.txt > Hunk #1 FAILED at 27 > 1 out of 1 hunks FAILED -- saving rejects to file > build/sanitizers/lsan_suppressions.txt.rej > patch failed, unable to continue (try -v) > patch failed, rejects left in working dir > errors during apply, please fix and refresh remove_suppressions > > Byron: could you take a look and maybe rebase, thanks! note this was for part 2. Part 1 was fine and landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/103cf4c29d7f
Keywords: leave-open
I've rebased this and will push it in a bit.
Flags: needinfo?(docfaraday)
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/5637f948d184
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: