Closed
Bug 1055873
Opened 10 years ago
Closed 10 years ago
[Remove], [Remove all] by mouse are broken in sub-dialog
Categories
(Firefox :: Settings UI, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox31 | --- | unaffected |
firefox32 | --- | unaffected |
firefox33 | - | unaffected |
firefox34 | - | unaffected |
firefox35 | --- | verified |
People
(Reporter: alice0775, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
See http://forums.mozillazine.org/viewtopic.php?p=13724777#p13724777
Regression window(fx)
Good:
https://hg.mozilla.org/integration/fx-team/rev/5f57fb99ab5c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140709024742
Bad:
https://hg.mozilla.org/integration/fx-team/rev/77728b5c5d7d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140709025430
Pushlog:
https://bugzilla.mozilla.org/show_bug.cgi?id=1035540
Regressed by:
ab15179de7d9 Richard Marti — Bug 1035540 - Convert Security pane dialogs to be in-content. r=MattN
Mozilla should provide TEST(manually/automatic)!
Reporter | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Blocks: ship-incontent-prefs
Assignee | ||
Comment 2•10 years ago
|
||
With actual Nightly and self built Firefox from tip I can remove the entries in in-content- and normal dialogs. Is there something else I have to do to see this issue?
The patch had also nothing changed in exceptions dialog, only the call to open it was changed.
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #2)
> With actual Nightly and self built Firefox from tip I can remove the entries
> in in-content- and normal dialogs. Is there something else I have to do to
> see this issue?
>
Nothing special.
I can reproduce the problem on normal nightly and latest tip ffdd1a398105 on windows7 x64 and ubuntu i686.
Steps To Reproduce
1. Start Browser with newly clean profile
2. Login this site
3. Select "Never Remember for This Site" in door hanger popup
4. Open Preferences (Alt > Edit > Preferences | Alt > Tools > Options)
5. Select "Security" pane
6. Click [Exceprions...] button of Passwords group
7. Select a entry item in the list view of "Exceprions-Saved Passwords" sub-dialog
8. Click [Remove]
--- The entry stays here
9. Click [Remove all]
--- The entry stays here
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(richard.marti)
Reporter | ||
Updated•10 years ago
|
OS: Windows 7 → All
Reporter | ||
Comment 4•10 years ago
|
||
FYI,
Mouse click of these buttons is broken.
Keypres ENTER of these buttons is working as expected.
Summary: [Remove], [Remove all] are broken in sub-dialog → [Remove], [Remove all] by mouse are broken in sub-dialog
Reporter | ||
Comment 5•10 years ago
|
||
It seems fix the problem when the following CSS is applied to the xul button elements.
-moz-user-select: none;
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Alice0775 White from comment #4)
> FYI,
> Mouse click of these buttons is broken.
> Keypres ENTER of these buttons is working as expected.
This helped a lot. It's again this rule which breaks: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#17
Matthew, what would be the best here? Should I add only a -moz-user-select: none; rule for the buttons?
I'm also thinking about moving this rule back from global to preferences as it breaks also a lot in Add-ons manager (bug 989469).
Flags: needinfo?(richard.marti) → needinfo?(MattN+bmo)
Reporter | ||
Comment 7•10 years ago
|
||
[Tracking Requested - why for this release]:
status-firefox34:
--- → affected
tracking-firefox34:
--- → ?
Comment 8•10 years ago
|
||
Based on the description, I'm marking 33 and 34 as affected and tracking both releases.
status-firefox31:
--- → unaffected
status-firefox32:
--- → unaffected
status-firefox33:
--- → affected
tracking-firefox33:
--- → +
Assignee | ||
Comment 9•10 years ago
|
||
Added button with -moz-user-select: none;. I think, the best is to move the -moz-user-select back to the in-content prefs. This was added to make text on the prefs selectable and isn't needed on other places like Add-on manager.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8481981 -
Flags: review?(MattN+bmo)
Updated•10 years ago
|
Flags: firefox-backlog+
Comment 10•10 years ago
|
||
Attachment #8481981 -
Flags: review?(MattN+bmo) → review+
Flags: needinfo?(MattN+bmo)
Updated•10 years ago
|
Flags: qe-verify?
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 11•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 12•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
Iteration: --- → 35.2
Comment 13•10 years ago
|
||
in-content prefs are only on Nightly, so I don't see how this could be relevant to Firefox 33/34.
Updated•10 years ago
|
Flags: qe-verify? → qe-verify+
Updated•10 years ago
|
QA Contact: jbecerra
Comment 15•10 years ago
|
||
Assigning to Camelia since she's in charge of In-Content Preferences, and is likely to have the time to take this.
QA Contact: jbecerra → camelia.badau
Comment 16•10 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 35.0a1 (buildID: 20140921030208).
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•