Closed Bug 1056017 Opened 10 years ago Closed 10 years ago

[Arabic] Display problem in Settings App - RTL Support Required.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

defect
Not set
normal

Tracking

(tracking-b2g:+, b2g-v2.2 verified)

VERIFIED FIXED
tracking-b2g +
Tracking Status
b2g-v2.2 --- verified

People

(Reporter: s2dar, Assigned: eragonj)

References

Details

Attachments

(5 files)

Attached image IMAG0069.jpg (deleted) —
User Agent: Mozilla/5.0 (Windows NT 6.3; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release) Build ID: 20140716183446 Steps to reproduce: 1. In settings go to language 2. Select language as "Arabic" 3. Click "ok" 4. Go click on anything Actual results: Distorted display when selecting the Arabic language. Expected results: A normal display in Arabic
Component: General → Gaia
I confirm it's true. I have been excepting this even though didn't get a chance to see it live. But technically this is happening. Will see if I can build a Flatfish Gaia profile and be able to inspect it. If so, I'll assign this to me.
Status: UNCONFIRMED → NEW
Component: Gaia → Gaia::Settings
Ever confirmed: true
Flags: needinfo?(swilkes)
Summary: [Flatfish][Arabic] Display problem. → [Flatfish][Arabic] Display problem in Settings App - RTL Support Required.
That sounds good, Ahmed. When this is ready for review, I can flag Jenny Lee or Omega Feng as they work on Settings on our end. Thank you!
Flags: needinfo?(swilkes)
Attached file PR to Github (deleted) —
Will add a review? flag as soon as I'm done cleaning the code and fixing any other glitches I can find. However it's pretty much done as of now. Adding a screenshot for a first feedback..
Attached image Screenshot - After Patch (deleted) —
Hey Stephany, I'd like to get some feedback on this :) Thanks!
Attachment #8492762 - Flags: feedback?(swilkes)
Attachment #8492762 - Flags: feedback?(swilkes) → feedback+
Looks really good to me, Ahmed - thanks! When it's ready for code review we can flag a developer for review?/+. :)
Comment on attachment 8492761 [details] PR to Github Updated :) Eventually decided to use -moz-padding-start, -end, and same for margins to reduce the change needed for RTL-specific styles on the long term.
Attachment #8492761 - Flags: ui-review?(jelee)
Attachment #8492761 - Flags: review?(ejchen)
Attachment #8492761 - Flags: ui-review?(jelee) → ui-review+
Blocks: settings-rtl
No longer blocks: gaia-rtl
Comment on attachment 8492761 [details] PR to Github Hi Ahmed, this patch looks nice to me and I left some comments on Github ! Please go check it when you have time. There are still rooms for us to improve rtl in Flatfish and I really appreciate you just made a good start ! Thanks :)
Attachment #8492761 - Flags: review?(ejchen)
feature-b2g: --- → 2.2+
not flatfish only
Summary: [Flatfish][Arabic] Display problem in Settings App - RTL Support Required. → [Arabic] Display problem in Settings App - RTL Support Required.
blocking-b2g: --- → backlog
I'll help this bug.
Assignee: nobody → ejchen
Attached file patch on master (2.2) (deleted) —
Arthur, can you help me review this patch for tablet !? THanks :)
Attachment #8528770 - Flags: review?(arthur.chen)
Comment on attachment 8528770 [details] patch on master (2.2) r=me with the comment addressed, thanks.
Attachment #8528770 - Flags: review?(arthur.chen) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Remove the feature b2g tag to match the new v2.2 scope.
feature-b2g: 2.2+ → ---
Keywords: verifyme
This issue is verified successfully in latest Flame2.2. STRs: 1. Chnage system language to Arabic. 2. Check Settings app. **The sorts are adapted to Arabic normally. See attachment Verify_RTL_Flame2.2.mp4 Flame 2.2 build version: Gaia-Rev cd42b034fd2825c3675ace3a67f5775eb61c2d60 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d824c65a6a2b Build-ID 20150128002506 Version 37.0a2 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150128.035910 FW-Date Wed Jan 28 03:59:20 EST 2015 Bootloader L1TC000118D0
Status: RESOLVED → VERIFIED
Keywords: verifyme
Attached video Verify_RTL_Flame2.2.MP4 (deleted) —
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15558/
Flags: in-moztrap+
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: