Closed
Bug 1056031
Opened 10 years ago
Closed 8 years ago
Show search icon in about:privatebrowsing instead of Firefox logo
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox34 affected, firefox35 affected, firefox36 affected, firefox37 affected, firefox38 affected, firefox39 affected, firefox40 affected, firefox41 affected, firefox42 affected)
People
(Reporter: CristinaM, Unassigned, Mentored)
References
Details
(Whiteboard: [lang=java][see comment 7+])
Attachments
(1 file)
Private mode with search icon
Environment
Device: Motorola Razr Android 4.1.2
Build: Firefox For Android 34.0a1 (2014-08-20)
Steps to reproduce:
1. Launch Fennec;
2. Go to Settings -> New Private Tab;
3. Observe the URL bar.
Expected results:
A search icon is displayed in the URL bar of the about:privatebrowsing page.
Actual results:
Firefox logo is displayed in the URL bar of the about:privatebrowsing page.
|
||
Updated•10 years ago
|
Blocks: new-toolbar-v1
|
|
||
Updated•10 years ago
|
Assignee: nobody → lucasr.at.mozilla
No longer blocks: new-toolbar-v1
|
|
||
Comment 1•10 years ago
|
||
The search icon looks a bit dim when in private mode. Would you like to use a search icon with a brighter grey tone?
Attachment #8475879 -
Flags: feedback?(alam)
|
||
Comment 2•10 years ago
|
||
Maybe we should look at Bug 864958 before we try to address this?
It's easy to produce a new icon for this but if we're going to update the private browsing chrome anyways we should probably do that first and see if we can maybe even reuse the same icon and save some space.
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8475879 [details]
Private mode with search icon
Yeah that's too dark right now..
Attachment #8475879 -
Flags: feedback?(alam) → feedback-
|
Reporter | |
Updated•10 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → affected
|
|
Reporter | |
Updated•10 years ago
|
status-firefox36:
--- → affected
|
|
||
Updated•10 years ago
|
Assignee: lucasr.at.mozilla → nobody
|
|
Reporter | |
Updated•10 years ago
|
status-firefox37:
--- → affected
status-firefox38:
--- → affected
|
||
Comment 4•9 years ago
|
||
Affects 42 so presumably affects the in-between version.
status-firefox39:
--- → affected
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox42:
--- → affected
|
|
||
Updated•9 years ago
|
Blocks: fennec-pb-v1
|
|
||
Updated•9 years ago
|
Assignee: nobody → michael.l.comella
|
|
||
Comment 5•9 years ago
|
||
Not actively working on this.
Assignee: michael.l.comella → nobody
Blocks: fennec-polish
|
|
||
Comment 6•9 years ago
|
||
Anthony, I assume we still want to do this? If so, what color should the magnifying glass be?
Flags: needinfo?(alam)
|
|
||
Comment 7•9 years ago
|
||
Our placeholder grey (#777777) by default. And our tabs tray icon grey for active (#AFB1B3) which is (I think) what we currently already do on tablets.
Flags: needinfo?(alam)
|
|
||
Comment 8•9 years ago
|
||
You should be able to use @drawable/search_icon_active with the android:tint functionality (or DrawableCompat [1] if it needs to be dynamic).
[1]: https://developer.android.com/reference/android/support/v4/graphics/drawable/DrawableCompat.html
Mentor: michael.l.comella, mhaigh
Whiteboard: [lang=java][see comment 7+]
|
||
Comment 10•8 years ago
|
||
Anthony and I realized that Nightly is already showing the search icon in the right colour when in Private Browsing. No UI is needed, and no Front-End changes need to be made. Hooray!
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(rvazquez)
Resolution: --- → FIXED
|
|
||
Updated•8 years ago
|
Resolution: FIXED → INVALID
|
Assignee | |
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•