Closed
Bug 1056256
Opened 10 years ago
Closed 10 years ago
Update invocation of setTextureCacheLimits to its new name
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Build warning:
{
2:04.12 Warning: -Wdeprecated-declarations in $SRCDIR/gfx/thebes/gfxPlatform.cpp: 'setTextureCacheLimits' is deprecated
2:04.13 $SRCDIR/gfx/thebes/gfxPlatform.cpp:870:32: warning: 'setTextureCacheLimits' is deprecated [-Wdeprecated-declarations]
2:04.13 mSkiaGlue->GetGrContext()->setTextureCacheLimits(cacheItemLimit, cacheSizeLimit);
2:04.13 ^
2:04.13 ../../dist/include/skia/GrContext.h:159:10: note: 'setTextureCacheLimits' has been explicitly marked deprecated here
2:04.13 void setTextureCacheLimits(int maxTextures, size_t maxTextureBytes) {
2:04.13 ^
}
It's only deprecated because it's been renamed:
> 157 void setResourceCacheLimits(int maxResources, size_t maxResourceBytes);
> 158 SK_ATTR_DEPRECATED("This function has been renamed to setResourceCacheLimits().")
> 159 void setTextureCacheLimits(int maxTextures, size_t maxTextureBytes) {
> 160 this->setResourceCacheLimits(maxTextures, maxTextureBytes);
> 161 }
http://mxr.mozilla.org/mozilla-central/source/gfx/skia/trunk/include/gpu/GrContext.h?rev=883cd6be06d2#159
The rename happened in a skia update that we took last month, in bug 1017113.
We should update the invocation in gfxPlatform.cpp to use the renamed version of this function.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
(Adding dependency on bug 939276, which added this line of code [before the skia update that renamed the function].)
Depends on: 939276
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #0)
> The rename happened in a skia update that we took last month, in bug 1017113.
er, s/last month/last week/. (I was initially going off of the July datestamp on the commit, but it lies.)
Updated•10 years ago
|
Attachment #8476121 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Flags: in-testsuite-
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•