When running the gtests in debug mode I get some warnings in the overscroll handoff tests. For example: [ RUN ] APZOverscrollHandoffTester.LayerStructureChangesWhileEventsArePending [5532] WARNING: Found a non-root APZ with no handoff parent: file /home/kats/zspace/mozilla-git/gfx/layers/apz/src/APZCTreeManager.cpp, line 1037 [5532] WARNING: Found a non-root APZ with no handoff parent: file /home/kats/zspace/mozilla-git/gfx/layers/apz/src/APZCTreeManager.cpp, line 1037 [ OK ] APZOverscrollHandoffTester.LayerStructureChangesWhileEventsArePending (0 ms)

Comment on attachment 8476678 [details] [diff] [review] Patch Review of attachment 8476678 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this! The test patch for bug 1042974 adds a CreateScrollgrabLayerTree() function, perhaps you can rebase and the SetScrollHandoff() lines to that one too before landing? ::: gfx/tests/gtest/TestAsyncPanZoomController.cpp @@ +1742,5 @@ > SetScrollableFrameMetrics(layers[3], FrameMetrics::START_SCROLL_ID + 2, CSSRect(0, 50, 100, 100)); > SetScrollableFrameMetrics(layers[4], FrameMetrics::START_SCROLL_ID + 3, CSSRect(0, 50, 100, 100)); > + SetScrollHandoff(layers[1], root); > + SetScrollHandoff(layers[2], layers[1]); > + SetScrollHandoff(layers[3], root); We don't give the root a scrollable FrameMetrics in this layer tree, so we can omit the 'layers[1] -> root' and 'layers[3] -> root' links.

Rebased to latest master and addressed review comments.