Closed Bug 1056884 Opened 10 years ago Closed 10 years ago

Implement special expanded Rocketbar state for homescreen and browser

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: benfrancis, Assigned: benfrancis)

References

Details

(Whiteboard: [systemsfe][p=3])

Attachments

(1 file)

The Rocketbar should be expanded by default on the homescreen and the browser (search) app but it needs a special state with just "Search or enter address" placeholder text instead of the app title. In this special state no navigation buttons should be displayed.
Assignee: nobody → bfrancis
I've implemented this just for the browser start page as we don't yet have the real Rocketbar on homescreen. I don't have the final assets for the search icon so have created placeholders by modifying the ones from the homescreen app. Eric, please let me know where I can find these so we can do an image swap later.
Attachment #8478475 - Flags: review?(kgrandon)
Flags: needinfo?(epang)
Cool - I also have a marionette test which should provide some additional title coverage that we may want to add to once these both land.
Comment on attachment 8478475 [details] https://github.com/mozilla-b2g/gaia/pull/23281 I am a bit concerned about the special casing spiraling out of control, but seems fine to land for now. Thanks!
Attachment #8478475 - Flags: review?(kgrandon) → review+
Target Milestone: --- → 2.1 S3 (29aug)
(In reply to Kevin Grandon :kgrandon from comment #3) > I am a bit concerned about the special casing spiraling out of control, but > seems fine to land for now. Thanks! Yeah, I agree. In my review of v0.12 of the Rocketbar spec I noted that there were 8 different variations of Rocketbar defined for various special cases. We've now managed to negotiate it down to 5 but I think we can reduce that more (e.g. by implementing real Rocketbar on the homescreen).
Integration tests are red on TBPL but seems unrelated, re-basing and pushing again.
(In reply to Ben Francis [:benfrancis] from comment #1) > Created attachment 8478475 [details] > https://github.com/mozilla-b2g/gaia/pull/23281 > > I've implemented this just for the browser start page as we don't yet have > the real Rocketbar on homescreen. > > I don't have the final assets for the search icon so have created > placeholders by modifying the ones from the homescreen app. Eric, please let > me know where I can find these so we can do an image swap later. Hey Ben, I've added the search icons here on box: https://mozilla.box.com/s/lh64n4krbkb9snuxnxcx Let me know if anything else is needed. Thanks!
Flags: needinfo?(epang)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: