Closed
Bug 1057075
Opened 10 years ago
Closed 10 years ago
New & Popular have a Editorial Brand icon, they shouldn't
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P3)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: pwalm, Unassigned)
References
Details
Attachments
(2 files)
Please remove the icons from the top of the New and Popular lists. Center the text to the page and set it in the Desktop & Tablet H1 style or the Mobile H3 style, depending on platform. Format the popular text as "Popular – All Time".
Thanks!
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
text style as per this link: http://pwalm.github.io/marketplace-style-guides/type.html
Removed the icons and center aligned the text.
PR -> https://github.com/mozilla/fireplace/pull/654
Flags: needinfo?(pwalmsley)
Reporter | ||
Comment 4•10 years ago
|
||
I think I spoke about it with someone (Chuck, maybe?) but I never put this in the bug: Can we remove the block background from these pages please? They should be individual blocks around the apps, not one big block for all the content on the page. The centered header will just sit on the grey background.
Thanks!
Flags: needinfo?(pwalmsley)
Comment 5•10 years ago
|
||
Trishul -- your PR is almost ready to go. Looks like just one thing left to do!
Updated•10 years ago
|
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•