Closed
Bug 105719
Opened 23 years ago
Closed 19 years ago
nsObserverService::Notify can avoid QI/ADDREF
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
WORKSFORME
Future
People
(Reporter: dougt, Unassigned)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
nsObserverService::Notify can avoid QI/ADDREF by accessing the nsObserverList's
nsISupportsArry directly.
|
||
Comment 1•23 years ago
|
||
another suggestion is to move the notification logic into nsObserverList - by
adding a public method to notify observers in the list.
|
Reporter | |
Comment 2•23 years ago
|
||
also see 55228
also, we should set some state so that we do not have to QI every observer for a
weak reference.
|
|
Reporter | |
Comment 3•23 years ago
|
||
Reduces QI and enumeration object create during notification. Inital Perf
timing is about 1.5x faster although clocked time is < a 200 microsecond
difference.
|
|
Reporter | |
Comment 4•23 years ago
|
||
The perf delta is low. Moving out
Keywords: perf
Target Milestone: mozilla0.9.7 → mozilla0.9.9
|
|
Reporter | |
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → Future
|
||
Updated•19 years ago
|
Assignee: dougt → nobody
QA Contact: scc → xpcom
|
|
||
Comment 5•19 years ago
|
||
Fixed by bug 326491, I believe.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•