According to docs, where supposed to flag input discontinuities to AudioFileStreamParseBytes(). Set a flag on flush and use it to add the appropriate value the next time SubmitSample runs. In theory this races since ::Flush and ::SubmitSample run out of different TaskQueues, but we've just flushed mTaskQueue when we set it, so the change should be seen correctly.

Comment on attachment 8477718 [details] [diff] [review] Signal discontinuities to the AudioFileStreamParseBytes Review of attachment 8477718 [details] [diff] [review]: ----------------------------------------------------------------- I think for thread safety, you should actually put a task onto the queue that sets mFlushed to true on the task queue, rather than setting it on the decode task queue thread and hoping there's a memory barrier in between setting it and it next being read on the other task queue thread when it's used. There probably will be a memory barrier, but I think it's best to be careful. You could also make it atomic.

Dispatch a task to update mFlushed to avoid thread safety concerns.

Comment on attachment 8477747 [details] [diff] [review] Signal discontinuities to the AudioFileStreamParseBytes Review of attachment 8477747 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.