Closed
Bug 1057651
Opened 10 years ago
Closed 10 years ago
Remove excess padding from new_tablet_browser_toolbar edit_cancel
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
(Whiteboard: [fixed-larch])
Attachments
(1 file)
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Via bug 1046203 comment 12:
@@ +112,5 @@
> + style="@style/UrlBar.ImageButton.Icon"
> + android:layout_alignParentRight="true"
> + android:src="@drawable/close_edit_mode_selector"
> + android:paddingLeft="2dp"
> + android:paddingRight="2dp"
> Not specific to this patch but I wonder if this padding is actually necessary. > Please file a follow-up to remove it from all *browser_toolbar.xml if it's not.
|
Assignee | |
Comment 1•10 years ago
|
||
It's not necessary.
Attachment #8478598 -
Flags: review?(lucasr.at.mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 2•10 years ago
|
||
bug 1058277 for this in m-c.
|
|
Assignee | |
Updated•10 years ago
|
Summary: Investigate whether new_tablet_browser_toolbar padding is necessary → Remove excess padding from new_tablet_browser_toolbar edit_cancel
|
||
Updated•10 years ago
|
Attachment #8478598 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [fixed-larch]
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•