Closed
Bug 1057798
Opened 10 years ago
Closed 10 years ago
Clean up mozL10n API use in Email
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: karanluthra06, Assigned: karanluthra06, Mentored)
References
Details
Attachments
(1 file)
No description provided.
Updated•10 years ago
|
Assignee: nobody → karanluthra06
Mentor: gandalf
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8477960 -
Flags: feedback?(gandalf)
Comment 2•10 years ago
|
||
Comment on attachment 8477960 [details]
Pull request for an attempt at this bug
Cool! That's a great first patch! Congratulations :)
There are two areas which I believe we could tackle in email:
- Toaster can take l10nId for it's Toaster.toast(opts.text) and assign l10nId instead of settings textContent
- The whole api.useLocalizedStrings should operate on l10nId's, not strings as well.
From what I understand, you'd prefer to land this patch and work on the follow up for those two? Sounds good to me!
I picked James as your reviewer since his review queue is empty (yay!). James, if you find a moment, that's just a clean up patch :)
Attachment #8477960 -
Flags: review?(jrburke)
Attachment #8477960 -
Flags: feedback?(gandalf)
Attachment #8477960 -
Flags: feedback+
Comment 3•10 years ago
|
||
(In reply to Zibi Braniecki [:gandalf] from comment #2)
> - The whole api.useLocalizedStrings should operate on l10nId's, not strings
> as well.
Please see bug 855198 and bug 1037266 for this part. (Bug 905869 is related but covers an expansion of folder names we localize.)
Comment 4•10 years ago
|
||
Comment on attachment 8477960 [details]
Pull request for an attempt at this bug
r+ if a couple of small nits about removing the `navigator.`, mentioned in the pull request, are fixed. If those are fixed, feel free to ping me or comment again in this bug, and I can do the merge.
Attachment #8477960 -
Flags: review?(jrburke) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Sorry for the delay, I just updated the PR.
https://github.com/mozilla-b2g/gaia/pull/23246
Started taking a look at Zibi's and Andrew's inputs as well.
Thanks!
Comment 6•10 years ago
|
||
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/5dbbd4ee09de929d6c388d19f128c902ac7d108f
from pull request:
https://github.com/mozilla-b2g/gaia/pull/23246
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•