Closed
Bug 1058043
Opened 10 years ago
Closed 10 years ago
ServiceWorkerRegistration should not keep a reference to the window
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: baku, Assigned: nsm)
References
Details
Attachments
(3 files, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8478276 -
Flags: review?(nsm.nikhil)
|
Assignee | |
Updated•10 years ago
|
Attachment #8478276 -
Flags: review?(nsm.nikhil) → review+
|
|
Reporter | |
Comment 2•10 years ago
|
||
Attachment #8478276 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
|
Assignee | |
Comment 6•10 years ago
|
||
StopListeningForEvents() should be called in the dtor too (with appropriate checks), in case the registration is GCed before the window goes away.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•10 years ago
|
||
Attachment #8480111 -
Flags: review?(amarchesini)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: amarchesini → nsm.nikhil
Status: REOPENED → ASSIGNED
|
|
Reporter | |
Comment 8•10 years ago
|
||
Comment on attachment 8480111 [details] [diff] [review]
Patch 2 - StopListeningForEvents in destructor
Review of attachment 8480111 [details] [diff] [review]:
-----------------------------------------------------------------
We wrote the same patch :)
We should call RemoveReadyPromise() in the dtor of ServiceWorkerContainer as well.
Attachment #8480111 -
Flags: review?(amarchesini) → review+
|
|
Reporter | |
Comment 9•10 years ago
|
||
Attachment #8480465 -
Flags: review?(nsm.nikhil)
|
|
Assignee | |
Comment 10•10 years ago
|
||
Comment on attachment 8480465 [details] [diff] [review]
patch 3 - ServiceWorkerContainer
Review of attachment 8480465 [details] [diff] [review]:
-----------------------------------------------------------------
Shouldn't this patch be attached to the .ready bug? Please update the commit message when landing.
Attachment #8480465 -
Flags: review?(nsm.nikhil) → review+
|
|
Assignee | |
Comment 12•10 years ago
|
||
|
|
||
Comment 13•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•